Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need feedback when user enters ThingsBoard parameters #21

Open
mhlmhl opened this issue Sep 17, 2024 · 1 comment
Open

Need feedback when user enters ThingsBoard parameters #21

mhlmhl opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mhlmhl
Copy link
Collaborator

mhlmhl commented Sep 17, 2024

2024-09-17 12_00_38-Node-RED Dashboard — Mozilla Firefox The "Iot Hub (ThingsBoard) / ThingsBoard Parameters" setup screen gives no feedback when the user enters the parameters. See attached image.

Current experience: user enters 3 fields (URL, port, access token) and hits submit. All three fields are then blanked out with no indication whether the entered data is correct or not.

  • UI should give feedback indicating success (ability to connect to TB with supplied parameters) or failure.
  • Ideally, the UI should indicate which field is wrong, e.g. by outlining it in red. This may not be possible in the case of a timeout, but it might be possible to distinguish particular errors, such as DNS failure when looking up the server URL.
  • Rather than automatically blanking out all three fields, it would be much kinder to users if they previously-entered parameters are left unchanged so that the user can just correct the fields that are wrong.
  • I'm told that the UI automatically defaults the port if left blank. That should be noted on the screen.
@glossyio glossyio added enhancement New feature or request good first issue Good for newcomers labels Sep 19, 2024
@glossyio
Copy link
Owner

I agree- This would be worth taking a look at again. Some thoughts:

  • This should more tightly be integrated with the node-red-project/environment file. Perhaps we should only handle these variables through the environment file, similar to Frigate's config?
  • Right now we're only using ThingsBoard HTTP APIs, but we should plan to have variables for MQTT APIs, too. So, we'll need port designations for both.
  • We'd also need a fleshed out UX, pre-filled fields, etc.
  • Agree on test/success/failure indicator for it.

Maybe we handle this as we move towards Node-RED Dashboard-2? Since node-red-dashboard is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants