Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectIcon typescript error using "mr=$3" #1454

Closed
1 of 6 tasks
faorte opened this issue Dec 6, 2023 · 4 comments
Closed
1 of 6 tasks

SelectIcon typescript error using "mr=$3" #1454

faorte opened this issue Dec 6, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@faorte
Copy link

faorte commented Dec 6, 2023

Description

In documentation for Select component the example for SelectIcon shows using prop mr=$3 but this generates a typescript error

CodeSandbox/Snack link

No response

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

gluestack-ui Version

1.0.8

Platform

  • Expo
  • React Native CLI
  • Next
  • Web
  • Android
  • iOS

Other Platform

No response

Additional Information

Screenshot 2023-12-06 at 12 41 27
Screenshot 2023-12-06 at 12 41 51

@faorte faorte added the bug Something isn't working label Dec 6, 2023
@surajahmed
Copy link
Contributor

@faorte Can you please try the latest version of @gluestack-style/react and @gluestack-ui/themed?

@faorte
Copy link
Author

faorte commented Dec 8, 2023

I am using "@gluestack-style/react": "^1.0.26",
"@gluestack-ui/config": "^1.0.8",
"@gluestack-ui/themed": "^1.0.24",

@StanislavDalinin
Copy link

StanislavDalinin commented Dec 10, 2023

Hello there, I've probably got the same issue, but a clearer type description.
The problem is not in the mr=$3 property but in the child. The type error tells us that the SelectIcon doesn't allow any children.

Screenshot 2023-12-10 at 22 54 03

I use gluestack-ui with solito, so probably my platforms are Expo, Next, Web, Android, iOS.
And I've installed the latest versions of the packages:
"@gluestack-style/react": "^1.0.26",
"@gluestack-ui/config": "^1.0.8",
"@gluestack-ui/themed": "^1.0.24",

@Gluant101 Gluant101 moved this from Backlog to In Progress in gluestack support Dec 12, 2023
@surajahmed surajahmed assigned ankit-tailor and unassigned mayank-96 Jan 15, 2024
@Viraj-10 Viraj-10 added this to the @gluestack-ui/themed@next milestone Jan 24, 2024
@ankit-tailor
Copy link
Contributor

Hey @faorte, The issue is fixed in the latest versions of @gluestack-style/react and @gluestack-ui/themed. Let me know if you face any issues.

@github-project-automation github-project-automation bot moved this from In Progress to Done in gluestack support Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants