Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not respecting phone's safe area #1462

Closed
1 of 6 tasks
madelineleclair opened this issue Dec 7, 2023 · 4 comments
Closed
1 of 6 tasks

Modal not respecting phone's safe area #1462

madelineleclair opened this issue Dec 7, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@madelineleclair
Copy link

Description

Modal not respecting safe area of phone

CodeSandbox/Snack link

No response

Steps to reproduce

  1. Create a modal
  2. Have it take up the the entire height of the phone
  3. The modal takes up all the space and runs into the power bar

Image

gluestack-ui Version

1.0.24

Platform

  • Expo
  • React Native CLI
  • Next
  • Web
  • Android
  • iOS

Other Platform

No response

Additional Information

The default modal should use a max height so it doesn't run into this issue.

@madelineleclair madelineleclair added the bug Something isn't working label Dec 7, 2023
@Viraj-10
Copy link
Collaborator

Viraj-10 commented Dec 8, 2023

Hey @madelineleclair, Can you share small reproduction of code with snack or github repo?

@madelineleclair
Copy link
Author

@Viraj-10 I created a public repo to show the bug. I am using ios to reproduce it. Use npm run ios to start the expo app.

@Gluant101 Gluant101 moved this from Backlog to Todo in gluestack support Dec 12, 2023
@Gluant101 Gluant101 moved this from Todo to In Progress in gluestack support Dec 12, 2023
@Viraj-10 Viraj-10 added this to the @gluestack-ui/themed@next milestone Jan 24, 2024
@rajat693
Copy link
Collaborator

hi @madelineleclair, you can take reference from this:- https://snack.expo.dev/@rajat693/modal-gluestack-ui

@Viraj-10
Copy link
Collaborator

Viraj-10 commented Feb 1, 2024

@madelineleclair, As shown in example user has to control SafeArea in project. As we don't want to force users to use any third party library. User have freedom to choose third party library to achieve this behaviour or create custom safearea logic.
We will try to add docs regarding the same.
Thanks for reporting this issue.

@Viraj-10 Viraj-10 closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in gluestack support Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants