From 3aa26dfb078d75f7bc21a913e9c74a7c3e4e5e58 Mon Sep 17 00:00:00 2001 From: sra1kumar-NULL Date: Wed, 13 Mar 2024 15:02:11 +0530 Subject: [PATCH 1/4] fix: minor ui color & theme issues --- .../src/components/Accordion/index.themed.stories.mdx | 4 +++- .../components/AlertDialog/index.themed.stories.mdx | 8 ++++++-- .../src/components/Badge/index.themed.stories.mdx | 3 +-- .../src/components/Input/index.themed.stories.mdx | 2 +- .../src/components/Progress/index.themed.stories.mdx | 2 +- .../src/components/Toast/index.themed.stories.mdx | 10 +++++----- .../src/components/Tooltip/index.themed.stories.mdx | 4 ++-- 7 files changed, 19 insertions(+), 14 deletions(-) diff --git a/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx index 38d2a3e00e..9751bfcd0b 100644 --- a/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx @@ -25,9 +25,11 @@ import { AccordionContentText, ChevronDownIcon, ChevronUpIcon, +} from '../../core-components/themed'; +import { PlusIcon, MinusIcon, -} from '../../core-components/themed'; +} from 'lucide-react-native'; import { AppProvider, CodePreview, diff --git a/example/storybook-nativewind/src/components/AlertDialog/index.themed.stories.mdx b/example/storybook-nativewind/src/components/AlertDialog/index.themed.stories.mdx index 05961e2c49..5a2df24473 100644 --- a/example/storybook-nativewind/src/components/AlertDialog/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/AlertDialog/index.themed.stories.mdx @@ -30,9 +30,13 @@ import { ButtonGroup, Center, HStack, - AlertTriangleIcon, - Text, CheckCircleIcon,Heading, Icon, AlertCircleIcon + Text, + CheckCircleIcon, + Heading, + Icon, + AlertCircleIcon } from '../../core-components/themed'; +import {AlertTriangleIcon} from 'lucide-react-native'; import { transformedCode } from '../../utils'; import { AppProvider, diff --git a/example/storybook-nativewind/src/components/Badge/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Badge/index.themed.stories.mdx index 92552fd270..d7df0507d7 100644 --- a/example/storybook-nativewind/src/components/Badge/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Badge/index.themed.stories.mdx @@ -37,6 +37,7 @@ import { Button, ButtonText, Badge, + Text, } from '../../core-components/themed'; import { PaintBucket, @@ -48,7 +49,6 @@ import { import { AppProvider, CodePreview, - Text, Table, TableContainer, InlineCode, @@ -336,7 +336,6 @@ A Badge component used with a menu adds a visual indicator, such as a badge, to ); }} - bg='$white' > diff --git a/example/storybook-nativewind/src/components/Input/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Input/index.themed.stories.mdx index c22f8bf28d..7c7c30a92f 100644 --- a/example/storybook-nativewind/src/components/Input/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Input/index.themed.stories.mdx @@ -544,7 +544,7 @@ The Input component integrates with an icon and a button, providing users with a setShowModal(false); }} > - + Save diff --git a/example/storybook-nativewind/src/components/Progress/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Progress/index.themed.stories.mdx index f3e4e9a5dd..a7cb2ecffa 100644 --- a/example/storybook-nativewind/src/components/Progress/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Progress/index.themed.stories.mdx @@ -17,7 +17,6 @@ import { Meta } from '@storybook/addon-docs'; import { AppProvider, CodePreview, - Text, Table, TableContainer, InlineCode, @@ -29,6 +28,7 @@ import { VStack, Box, Heading, + Text } from '../../core-components/themed'; import { transformedCode } from '../../utils'; import Wrapper from '../../core-components/themed/Wrapper'; diff --git a/example/storybook-nativewind/src/components/Toast/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Toast/index.themed.stories.mdx index cced321ef1..e37bfdbe87 100644 --- a/example/storybook-nativewind/src/components/Toast/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Toast/index.themed.stories.mdx @@ -21,15 +21,16 @@ import { useToast, Button, ButtonText, + Text } from '../../core-components/themed'; -import { CheckIcon, MessageCircle } from '@gluestack-ui/themed'; +import { CheckIcon } from '@gluestack-ui/themed'; +import { AlertTriangleIcon,MessageCircle } from 'lucide-react-native'; import { Icon, CloseIcon, VStack, - AlertTriangleIcon, Pressable, - Center, + Center } from '../../core-components/themed'; import { transformedCode } from '../../utils'; import { @@ -37,7 +38,6 @@ import { CodePreview, Table, TableContainer, - Text, InlineCode, CollapsibleCode } from '@gluestack/design-system'; @@ -868,7 +868,7 @@ A Toast component with preserve toast functionality retains the notification on const toastId = "toast-" + id; return ( - + Account Security Alert Your account password was recently changed. diff --git a/example/storybook-nativewind/src/components/Tooltip/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Tooltip/index.themed.stories.mdx index 5d59c00fd2..ec0ef8e95d 100644 --- a/example/storybook-nativewind/src/components/Tooltip/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Tooltip/index.themed.stories.mdx @@ -30,7 +30,8 @@ import { Center, VStack, Command, - Icon + Icon, + Text } from '../../core-components/themed'; import { transformedCode } from '../../utils'; import { @@ -38,7 +39,6 @@ import { CodePreview, Table, TableContainer, - Text, InlineCode, CollapsibleCode } from '@gluestack/design-system'; From 7d6f4efd05c30f1dbacd7e4d9259580dcbcf8654 Mon Sep 17 00:00:00 2001 From: sra1kumar-NULL Date: Thu, 14 Mar 2024 14:36:58 +0530 Subject: [PATCH 2/4] fix: added fixes minor ui issues reported --- .../Accordion/index.themed.stories.mdx | 2 +- .../Actionsheet/index.themed.stories.mdx | 12 ++--- .../Avatar/index.themed.stories.mdx | 2 +- .../Checkbox/index.themed.stories.mdx | 54 +++++++++---------- .../components/Fab/index.themed.stories.mdx | 22 ++------ .../FormControl/index.themed.stories.mdx | 10 ++-- .../components/Modal/index.themed.stories.mdx | 29 +++++----- .../Popover/index.themed.stories.mdx | 3 +- .../Pressable/index.themed.stories.mdx | 6 +-- .../Tooltip/index.themed.stories.mdx | 2 +- .../VStack/index.themed.stories.mdx | 9 ++-- 11 files changed, 66 insertions(+), 85 deletions(-) diff --git a/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx index 9751bfcd0b..690a714206 100644 --- a/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Accordion/index.themed.stories.mdx @@ -242,7 +242,7 @@ The borderRadius prop can be used to create rounded corners for both the Accordi code: ` function App(){ return ( - + +<> @@ -414,7 +414,7 @@ It inherits all the properties of React Native's [View](https://reactnative.dev/
- + #### ActionsheetBackdrop @@ -427,7 +427,7 @@ It inherits all the properties of [@legendapp/motion's](https://legendapp.com/op **Descendants Styling Props** Props to style child components. - +<> @@ -454,7 +454,7 @@ Props to style child components.
-
+ #### ActionsheetDragIndicatorWrapper @@ -471,7 +471,7 @@ It inherits all the properties of React Native's [Pressable](https://reactnative **Descendants Styling Props** Props to style child components. - +<> @@ -508,7 +508,7 @@ Props to style child components.
-
+ #### ActionsheetItemText diff --git a/example/storybook-nativewind/src/components/Avatar/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Avatar/index.themed.stories.mdx index 7a6ac491fe..1dcfaa8905 100644 --- a/example/storybook-nativewind/src/components/Avatar/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Avatar/index.themed.stories.mdx @@ -27,7 +27,6 @@ import { Text, Icon, Heading, - User, } from '../../core-components/themed'; import { transformedCode } from '../../utils'; import { @@ -38,6 +37,7 @@ import { InlineCode, CollapsibleCode } from '@gluestack/design-system'; +import { User } from 'lucide-react-native'; import Wrapper from '../../core-components/themed/Wrapper'; This is an illustration of **Avatar** component. diff --git a/example/storybook-nativewind/src/components/Checkbox/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Checkbox/index.themed.stories.mdx index d6b2448ed2..8a066a0259 100644 --- a/example/storybook-nativewind/src/components/Checkbox/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Checkbox/index.themed.stories.mdx @@ -22,7 +22,6 @@ import { CheckboxIcon, CheckboxLabel, Text, - RemoveIcon, FormControl, Icon, CheckIcon, @@ -34,7 +33,6 @@ import { } from '../../core-components/themed'; import { useState, useRef } from 'react'; import { transformedCode } from '../../utils'; - import { AppProvider, CodePreview, @@ -54,7 +52,7 @@ This is an illustration of **Checkbox** component. metaData={{ code: ` - + Label @@ -144,7 +142,7 @@ This section provides a comprehensive reference list for the component props, de Contains all Checkbox related layout style props and actions. It inherits all the properties of React Native's [View](https://reactnative.dev/docs/view) component. - +<> @@ -331,12 +329,12 @@ Contains all Checkbox related layout style props and actions. It inherits all th
-
+ **Descendants Styling Props** Props to style child components. - +<> @@ -383,7 +381,7 @@ Props to style child components.
-
+ #### CheckboxIndicator @@ -401,7 +399,7 @@ Contains all Label related layout style props and actions. It inherits all the p Contains all Group related layout style props and actions. It inherits all the properties of React Native's [View](https://reactnative.dev/docs/view) component. - +<> @@ -504,7 +502,7 @@ Contains all Group related layout style props and actions. It inherits all the p
-
+ ### Features @@ -541,7 +539,7 @@ Checkbox component is created using Pressable component from react-native. It ex #### Checkbox - +<> @@ -574,7 +572,7 @@ Checkbox component is created using Pressable component from react-native. It ex
-
+ ### Examples @@ -598,19 +596,19 @@ Checkbox provide a mutually exclusive selection mechanism, allowing users to cho }}> - + Framer - + Invision Studio - + Adobe XD @@ -659,19 +657,19 @@ A horizontal component incorporating a checkbox allows for intuitive and space-e }}> - + Illustration - + Animation - + Typography @@ -720,7 +718,7 @@ A checkbox component with help text provides informative guidance alongside sele - + Design @@ -729,7 +727,7 @@ A checkbox component with help text provides informative guidance alongside sele - + Marketing @@ -778,19 +776,19 @@ A checkbox component integrated with form control enhances the user experience b Sign up for newsletters - + Daily Bits - + Event Updates - + Sponsorship @@ -901,13 +899,13 @@ A controlled component architecture incorporates a checkbox component, allowing }}> - + UX Research - + Software Development @@ -958,13 +956,13 @@ function App() { - + Apartments - + Residents @@ -1018,7 +1016,7 @@ function CheckboxExample(){ isDisabled={true} value="Label 1" > - + Label 1 @@ -1026,7 +1024,7 @@ function CheckboxExample(){ - + Label 2 diff --git a/example/storybook-nativewind/src/components/Fab/index.themed.stories.mdx b/example/storybook-nativewind/src/components/Fab/index.themed.stories.mdx index a4efb0c3ed..64c39c642a 100644 --- a/example/storybook-nativewind/src/components/Fab/index.themed.stories.mdx +++ b/example/storybook-nativewind/src/components/Fab/index.themed.stories.mdx @@ -359,20 +359,6 @@ Fab component is created using Pressable component from react-native. It extends -## Spec Doc - -Explore the comprehensive details of the Fab in this document, including its implementation details, checklist, and potential future additions. Dive into the thought process behind the component and gain insights into its development journey. - -