-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring full compatibility between Double loop notebooks and upstream IDAES #154
Comments
Updated the title to reflect all double loop notebook Added new items:
|
@lbianchi-lbl How should I modify the checks.yml so that we can run the RE double loop notebook with the new CI env var? |
@dguittet In the on:
workflow_dispatch:
defaults:
run:
# important to make sure that all commands on Windows are run using Bash
# -l: login shell, needed when using Conda
shell: bash -l {0}
env:
DISPATCHES_TESTING_MODE: "true"
jobs:
# ... rest of the code |
@lbianchi-lbl Thanks. And the notebook is already enabled? |
@dguittet good point. The last several cells of That can be done:
|
Since it's not really connected to the IDAES v2 transition, I've created #159 to track the changes needed to be able to remove the |
Notebooks
DoubleLoopOptimization.ipynb
ThermalGeneratorModelData
seems to be missing from current IDAESPython code
Formerly part of this issue
Cell 10 raises exception on Linux because of capitalization issues in the GMLC-RTS dataset (see Fix issues due to capitalization sample-data#1)This is a separate issue and is being tracked in Enable "CI mode" with reduced runtime for double-loop notebooks #159The text was updated successfully, but these errors were encountered: