Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polymer-reg-sync-manipulator to fix compat for clients with Fabric API but not this mod installed #72

Closed
wants to merge 2 commits into from

Conversation

j5155
Copy link

@j5155 j5155 commented Aug 9, 2023

According to #67 (comment) this should fix the compatibility issue. I was having some trouble verifying that this worked so if someone who experienced the issue can check this it would be much appreciated.
Closes #67

@altrisi
Copy link

altrisi commented Aug 16, 2023

I think you have to call some method on it to register the block to not be synced, though I haven't used this library so I don't really know.

@j5155
Copy link
Author

j5155 commented Aug 16, 2023

That makes a lot of sense; I looked into it more and it seems you have to register it as server only using https://github.com/Patbox/polymer/blob/3a4d3c16cbbefcd69ae2b6d574b3098e7820904c/polymer-reg-sync-manipulator/src/main/java/eu/pb4/polymer/rsm/api/RegistrySyncUtils.java#L27, with an example at https://github.com/samolego/Taterzens/blob/8b0a332a715764240c7a856178c58bcfa23071a5/fabric/src/main/java/org/samo_lego/taterzens/fabric/TaterzensFabric.java#L47
Will work on implementing this later but converting this to draft for now
Edit: implemented

@j5155 j5155 marked this pull request as draft August 16, 2023 18:14
@j5155 j5155 marked this pull request as ready for review August 16, 2023 23:57
@j5155 j5155 closed this Mar 28, 2024
@j5155
Copy link
Author

j5155 commented Mar 28, 2024

Looks like Gnembon "upstreamed" this mod into Minecraft official lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with clients without the mod and with Fabric API on 1.20+ or exactly 0.79.0
2 participants