-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prop-types warning #7
Comments
Would you release a fix if I submit a PR? |
this now errors any chance you can publish a new version with the fix? |
Hey there, I found this library fits is super well with my needs! I had done some minors tweaks mostly on the tests and published react-tunnel-16 and made it work finely with CRA still need to figure how to make it work with react-native + react 16. I will send a PR once I have the tests passing. |
@agrcrobles I'll look for the PR Please note however that this lib is subject to the same limitations of context that say react-router is where a connected component can easily block updates. Have you looked at https://github.com/ReactTraining/react-broadcast instead? it implements a subscription model to avoid this and I would probably use this lib for my own future needs for this reason alone. If you aren't using shouldComponentUpdate then react-tunnel should still work well but that's a fairly large limitation. |
Thanks for the advice @gnoff! I will send a PR with my current stuffs as of now, as I made it work with CRA and react version 16.2. |
Get this when using react-tunnel:
Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
from:
The text was updated successfully, but these errors were encountered: