Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making r/users package grc721 compliant #297

Open
lumtis opened this issue Jul 16, 2022 · 3 comments
Open

Making r/users package grc721 compliant #297

lumtis opened this issue Jul 16, 2022 · 3 comments

Comments

@lumtis
Copy link
Contributor

lumtis commented Jul 16, 2022

Currently, the realm package users associates a user profile to an address, it seems the associated address for a name can no longer be updated after registration.

Is there a specific motivation or idea behind this not being possible?

This issue is about implementing the grc721 interface to make a User tokenised and transferable, which would allow:

  • Updating address when transitioning to a new account
  • Giving away or selling the name or the benefit of the user profile
@moul
Copy link
Member

moul commented Jul 19, 2022

We discussed this w/ Jae; in our case, the r/users is not exactly like an ENS, and we want to make it more unique (no way to have multiple ones on an individual address), but we also want to allow transferring it to another account.

  • Making it 100% grc721 compliant is not probable.
  • Implementing a transfer with some additional verifications is probable.
  • Implementing a transfer approved by the DAO in case of account stealing or something is another potential option.
  • Letting people implement an additional name registration system which works like ENS (full grc721) is another option.

Let's keep this discussion open to get more feedback and decide later.

FYI, r/users will be a later central point of the governance and will eventually be moved to something like r/system/users. Maybe it makes more sense to split the governance usernames completely from those specialized for NFTs and 2nd market usages. Or perhaps make the grc721 and see how things are going.

If we want to make it grc721, we also need to support new features like "selecting the main one" so we can call the realm to get a username from an address and always have the same.

@lumtis
Copy link
Contributor Author

lumtis commented Jul 19, 2022

FYI, r/users will be a later central point of the governance and will eventually be moved to something like r/system/users. Maybe it makes more sense to split the governance usernames completely from those specialized for NFTs and 2nd market usages. Or perhaps make the grc721 and see how things are going.

Thanks for bringing clarity on r/users, it makes sense to not consider grc721 if additional mechanisms like DAO approval are considered and it is more considered like a personal identity.

I saw some of the usage of r/users with r/boards and I was thinking of usage of the package where a user represents an organization identity and where the notion of NFT would make more sense IMO. But this could also actually be another package.

If we want to make it grc721, we also need to support new features like "selecting the main one" so we can call the realm to get a username from an address and always have the same.

You can actually keep an 1-1 relationship and be grc721 compliant, Transfer should fail if balance(recipient) != 0

@moul
Copy link
Member

moul commented Aug 2, 2022

You can keep a 1-1 relationship and be grc721 compliant, Transfer should fail if balance(recipient) != 0

Yep, this can be the solution.


But this could also actually be another package.

And, this can be the other one.

I think we'll have both, and maybe the two packages can communicate somehow. Perhaps r/system/users could be the top-level TLD, while r/names could be a "subdomain" feature that can be easily transferred.

@moul moul added this to the 💡Someday/Maybe milestone Oct 20, 2022
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔵 Not Needed for Launch
Development

No branches or pull requests

2 participants