Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seer - add subgraph to SubgraphHandler #501

Closed
gabrielfior opened this issue Oct 14, 2024 · 2 comments · Fixed by #535
Closed

Seer - add subgraph to SubgraphHandler #501

gabrielfior opened this issue Oct 14, 2024 · 2 comments · Fixed by #535
Assignees
Labels

Comments

@gabrielfior
Copy link
Contributor

gabrielfior commented Oct 14, 2024

@kongzii
Copy link
Contributor

kongzii commented Oct 15, 2024

Instead of adding seer to OmenSubgraphHandler, I vote for a new class, SeerSubgraphHandler. See this comment for the reasoning; TLDR is that OmenSubgraphHandler is already crowded, and it is hard to tell what's going on.

@gabrielfior
Copy link
Contributor Author

Agree with SeerSubgraphHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants