Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ArbitrageAgent answer_binary_market #521

Open
gabrielfior opened this issue Oct 15, 2024 · 1 comment
Open

Refactor ArbitrageAgent answer_binary_market #521

gabrielfior opened this issue Oct 15, 2024 · 1 comment

Comments

@gabrielfior
Copy link
Contributor

Implement as @kongzii suggested (or come up with more creative implementation)

image

To do once #511 is merged

@kongzii
Copy link
Contributor

kongzii commented Oct 23, 2024

If gnosis/prediction-market-agent-tooling#525 goes through in the review, then asnwer_and_build_trades function won't be possible anymore.

But I still think the goal here is doable, as a potential solution, I think we can do this:

Screenshot by Dropbox Capture

Then ArbitrageAgent can implement custom build_trades (as it's doing already) that doesn't care about the answer. And ArbitrageAgent can implement answer_binary_market simply as return None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants