Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting unchanged lines #32257

Open
kuraga opened this issue Oct 14, 2024 · 5 comments · May be fixed by #32259
Open

Commenting unchanged lines #32257

kuraga opened this issue Oct 14, 2024 · 5 comments · May be fixed by #32259
Labels
💎 Bounty type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kuraga
Copy link

kuraga commented Oct 14, 2024 •
edited
Loading

Feature Description

Now,
at the Pull request page,
at the Files Changed tab,
I can leave a comment in the patched lines only.
I can't leave a comment in the lines appear with the Fold up/Fold down button.

The proposition is to allow it.

Why? Sometimes we need to refer some lines outside of the patch.

Screenshots

No response
@kuraga kuraga added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 14, 2024
@techknowlogick
Copy link
Member

/bounty $200

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Oct 14, 2024 •
edited
Loading

💎 $200 bounty • Gitea

Steps to solve:

  1. Start working: Comment /attempt #32257 with your implementation plan
  2. Submit work: Create a pull request including /claim #32257 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to go-gitea/gitea!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @varshith257 Oct 14, 2024, 5:14:12 PM WIP
🟢 @abhishek818 Oct 14, 2024, 6:25:55 PM #32259

@varshith257
Copy link

varshith257 commented Oct 14, 2024 •
edited by algora-pbc bot
Loading

/attempt #32257

Algora profile Completed bounties Tech Active attempts Options
@varshith257 15 bounties from 7 projects
Go, Scala,
TypeScript & more
Cancel attempt

abhishek818 added a commit to abhishek818/gitea that referenced this issue Oct 14, 2024
@abhishek818
allow comments on non-diff lines (go-gitea#32257)
350613c 
Signed-off-by: abhishek818 <[email protected]>
@abhishek818 abhishek818 linked a pull request Oct 14, 2024 that will close this issue
Draft
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Oct 14, 2024 •
edited
Loading

💡 @abhishek818 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@abhishek818
Copy link

abhishek818 commented Oct 14, 2024 •
edited by algora-pbc bot
Loading

/attempt #32257

Algora profile Completed bounties Tech Active attempts Options
@abhishek818 23 bounties from 6 projects
Go, TypeScript,
Rust & more
Cancel attempt

abhishek818 added a commit to abhishek818/gitea that referenced this issue Oct 14, 2024
@abhishek818
allow comments on non-diff lines (go-gitea#32257)
a65f0f6 
Signed-off-by: abhishek818 <[email protected]>
@jpraet jpraet mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow comments on non-diff lines (#32257) abhishek818/gitea
4 participants
@techknowlogick @kuraga @abhishek818 @varshith257