Disable commits and file changes tab if user has no code unit permission

[yp05327]

Feature Description

Thanks @hakito's issue #32253.
There's another issue mentioned in the origin issue.
And you can also check the comment here: #32254 (comment)

updated:
And the review comment which can see the code changes.

Screenshots

No response

[lunny]

Pull request is a whole feature, I don't think it's meaningful to disable these two tabs. I don't know how the pull request works for the end user if there is no commit history and changed files.

[wxiaoguang]

It seems that this discussion doesn't get interests, and I do not see any benefit to make any change.

[hakito]

Actually for our setup it would be good to have access to PR without access to the commits and file changes.

We are doing branch based development. When a feature has been completed, we create a PR. In the PR we refer to the issues which are implemented on the branch.

The Product Owner reviews the branch builds and therefore needs to know which issues have been implemented on the branch/PR. He then approves the issues or requests changes.

But he shouldn't have access to the code parts.

[lunny]

Actually for our setup it would be good to have access to PR without access to the commits and file changes.

We are doing branch based development. When a feature has been completed, we create a PR. In the PR we refer to the issues which are implemented on the branch.

The Product Owner reviews the branch builds and therefore needs to know which issues have been implemented on the branch/PR. He then approves the issues or requests changes.

But he shouldn't have access to the code parts.

Sounds a bit reasonable. But there is already a pull request comment in this issue. Maybe that is enough?

[yp05327]

He then approves the issues or requests changes.

Does this mean approve the PR or request changes feature of Gitea?

Or just mean approve the work? e.g. It is ok to work on this issue/PR, and the code review is not related.
As approve/require changes need code write permission, I think we need to confirm it.

[hakito]

It just means approve the work. We have a code review after the Product Owner approved the changes. During this review the actual approval of the PR occurs.

[yp05327]

#32299 (comment)
mark