Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window/showDocument should be part of client instead of server #51

Open
mnoah1 opened this issue Oct 11, 2024 · 0 comments
Open

window/showDocument should be part of client instead of server #51

mnoah1 opened this issue Oct 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mnoah1
Copy link

mnoah1 commented Oct 11, 2024

Currently, the package includes ShowDocument as part of the Server interface. However, per LSP spec, this is actually a request from the server -> client, so it should be moved to the Client interface instead.

LSP Reference: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument
@zchee zchee added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zchee @mnoah1