From e1c9b4361671d1e3c2c974fc2be765d6b74b89f8 Mon Sep 17 00:00:00 2001 From: Liubomyr Manastyretskyi Date: Sat, 12 Aug 2023 18:42:51 +0300 Subject: [PATCH] Add comment for more clarity --- .github/workflows/on_release_publish.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/on_release_publish.yml b/.github/workflows/on_release_publish.yml index bb078b18d..958ef418d 100644 --- a/.github/workflows/on_release_publish.yml +++ b/.github/workflows/on_release_publish.yml @@ -188,7 +188,12 @@ jobs: with: ui: true - - name: Build and export to Docker + # Buildx can only output single-platform result image to docker + # so for testing purposes we are building only for linux/amd64 + # Later when we publish the image we build for linux/amd64 and linux/arm64 + # Note that linux/amd64 is cached, so when we build images for publishing + # we are not rebuilding linux/amd64 + - name: Build docker image for testing uses: docker/build-push-action@v4 with: context: . @@ -197,7 +202,7 @@ jobs: build-args: ${{ env.BUILD_ARGS }} tags: ${{ env.DOCKERHUB_ORG }}/${{ env.DOCKERHUB_REPO }}:${{ env.VERSION }} - - name: Test Image Build + - name: Test image build run: | docker run --rm ${DOCKERHUB_ORG}/${DOCKERHUB_REPO}:${VERSION} version