Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise deprecated #502

Open
beffge opened this issue Aug 31, 2023 · 6 comments
Open

Enterprise deprecated #502

beffge opened this issue Aug 31, 2023 · 6 comments

Comments

@beffge
Copy link
Contributor

beffge commented Aug 31, 2023

The enterprise is deprecated in the DSL and should be replaced with groups.

Could someone hint to all the places which might need changes for it to work?

@raphael
Copy link
Member

raphael commented Aug 31, 2023

Thanks for raising this! A good ol' search and replace should work pretty well here given that Enterprise is used mostly as metadata. Roughly the DSL has to be added (similar to this), then the group expression needs to be added (that the new group DSL would instantiate, similar to this), the ModelizeDesign function in the mdl package needs to be updated to take this new field into consideration. We should also probably test to make sure that the design serializes correctly for the structurizr service.

@raphael
Copy link
Member

raphael commented Oct 18, 2023

@beffge nudge: any chance you might be able to take a look?

@beffge
Copy link
Contributor Author

beffge commented Nov 6, 2023

Hey, sorry for responding so slow on your comment. I can't promise anything here timeline wise but it is till on my radar.

@beffge
Copy link
Contributor Author

beffge commented Mar 20, 2024

I just thought I'll look into this again. But I got a bit confused.

To me it looks more like the DeploymentEnv i.e. in the resulting JSON just a string and during modelling as a function. Difference is just, it can be at different locations as well as it can be nested.

With regards to being nested, it requires

        properties {
            "structurizr.groupSeparator" "/"
        }

for which I didn't find anything similar. How would you approach this?

@beffge
Copy link
Contributor Author

beffge commented Mar 21, 2024

OK, I tried to add it but got lost 😓 It seems like, since group can be part of Design, SoftwareSystem and Container as well as nested, it's more way more than just the existing Enterprise. I started adding it, but I was just assuming what I had to do, since I don't use anything but the mdl package. I'm pretty sure any PR I'd create would require a lot of discussion and rework i.e. it will be faster and more efficient if someone which uses the "other" parts implements it.

@raphael what do you think?

@raphael
Copy link
Member

raphael commented Mar 22, 2024

Fair enough! I'll keep the issue opened so one of us can take a look at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants