PROD-30018: Replace custom grequest with contrib grequest
#3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kingdutch
added
type: refactoring
|
Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them. Missing milestone 🤖 This is an automatically produced message by the Open Social PR manager. |
Kingdutch
force-pushed
the
feature/replace-grequest
branch
2 times, most recently
from
83fdf5c to
5c04cd2
Compare
Kingdutch
force-pushed
the
feature/replace-grequest
branch
2 times, most recently
from
033ec11 to
baa007c
Compare
This commit replaces the custom module, which came from a patch that was introduced before Group 1.4, with the current 2.2.2 version of the grequest module. The next steps are to then remove the module and pull it in through composer, but this commit gives a clear overview of the differences between our custom version and the contrib version at the time of the switch.
This replaces the in-repo copy of grequest with a copy that's installed with Composer from the Drupal packagist. This ensures that dependencies are also properly pulled in. We choose 2.2.2 which is the latest stable version and we lock it to match the current policy of other dependencies in the distribution.
There's a few differences between what was in our grequest module and what is in the version that's now in contrib that we're moving to. This requires some config and databae updates. These updates are placed in `social_group_request` under the assumption that all platforms that use `grequest` do so through this Open Social integration module. The upgrade path puts an updated Open Social as close as possible to a fresh install.
This changes the social_group_request module so that it integrates with the contrib version of the grequest module rather than our custom version. Most notably some constants are changes, but there's a small tweak in how membershiprequests can be fetched as well.
The config for the membership request functionality for flexible groups was included in `social_group_request`. However, the `social_group_request` module is a module whose purpose is to provide building blocks on top of `grequest` which other Open Social group types can re-use (e.g. discussions or courses). By moving the functionality into `social_group_flexible_group` we bring that module closer to containing all the (optional) functionality that is specific to the Flexible Groups _feature_, while keeping only the generic shared behaviour in social_group_request for the membership request _system_.
Kingdutch
force-pushed
the
feature/replace-grequest
branch
from
baa007c to
a5836cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the custom module, which came from a patch that was introduced before Group 1.4, with the current 2.2.2 version of the grequest module. The next steps are to then remove the module and pull it in through composer, but this commit gives a clear overview of the differences between our custom version and the contrib version at the time of the switch.
Problem
The grequest module provides a way to request access to a group. It was originally created as a patch for the Group module but it was decided to spin it out into a separate contrib module to keep the group module leaner. As part of our internal Group module update to Group 1.4 we did not have the time to switch from the patch to a contrib module so we included the patch as a custom module in our code-base.
Solution
The contrib version of the module has forms that work properly and contains additional improvements for group compatibility so we want to fulfill our long-term plan of moving from the custom patch version to the contrib module.
Issue tracker
https://getopensocial.atlassian.net/browse/PROD-30018
Theme issue tracker
How to test
Screenshots
Release notes
Change Record
Translations