From 8762740e89bd4c67a407f3db06ac0f1209168916 Mon Sep 17 00:00:00 2001 From: Patrick Pfeiffer Date: Fri, 9 Aug 2024 09:07:42 +0200 Subject: [PATCH] (NOBIDS) eth1indexer: less logging on ens --- db/ens.go | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/db/ens.go b/db/ens.go index a9e562e754..8904bc553e 100644 --- a/db/ens.go +++ b/db/ens.go @@ -15,7 +15,6 @@ import ( "github.com/gobitfly/eth2-beaconchain-explorer/metrics" "github.com/gobitfly/eth2-beaconchain-explorer/types" "github.com/gobitfly/eth2-beaconchain-explorer/utils" - "github.com/sirupsen/logrus" gcp_bigtable "cloud.google.com/go/bigtable" "golang.org/x/sync/errgroup" @@ -439,7 +438,7 @@ func validateEnsAddress(client *ethclient.Client, address common.Address, alread err.Error() == "no resolution" || err.Error() == "execution reverted" || strings.HasPrefix(err.Error(), "name is not valid") { - logger.Warnf("reverse resolving address [%v] resulted in a skippable error [%s], skipping it", address, err.Error()) + // logger.Warnf("reverse resolving address [%v] resulted in a skippable error [%s], skipping it", address, err.Error()) } else { return fmt.Errorf("error could not reverse resolve address [%v]: %w", address, err) } @@ -478,7 +477,7 @@ func validateEnsName(client *ethclient.Client, name string, alreadyChecked *EnsC nameHash, err := go_ens.NameHash(name) if err != nil { - logger.Warnf("error could not hash name [%v]: %v -> removing ens entry", name, err) + // logger.Warnf("error could not hash name [%v]: %v -> removing ens entry", name, err) err = removeEnsName(client, name) if err != nil { return fmt.Errorf("error removing ens name [%v]: %w", name, err) @@ -496,7 +495,7 @@ func validateEnsName(client *ethclient.Client, name string, alreadyChecked *EnsC err.Error() == "invalid jump destination" || err.Error() == "invalid opcode: INVALID" { // the given name is not available anymore or resolving it did not work properly => we can remove it from the db (if it is there) - logger.WithField("error", err).WithField("name", name).Warnf("could not resolve name") + // logger.WithField("error", err).WithField("name", name).Warnf("could not resolve name") err = removeEnsName(client, name) if err != nil { return fmt.Errorf("error removing ens name after resolve failed [%v]: %w", name, err) @@ -532,7 +531,7 @@ func validateEnsName(client *ethclient.Client, name string, alreadyChecked *EnsC reverseName, err := go_ens.ReverseResolve(client, addr) if err != nil { if err.Error() == "not a resolver" || err.Error() == "no resolution" || err.Error() == "execution reverted" { - logger.Warnf("reverse resolving address [%v] for name [%v] resulted in an error [%s], marking entry as not primary", addr, name, err.Error()) + // logger.Warnf("reverse resolving address [%v] for name [%v] resulted in an error [%s], marking entry as not primary", addr, name, err.Error()) } else { return fmt.Errorf("error could not reverse resolve address [%v]: %w", addr, err) } @@ -565,12 +564,12 @@ func validateEnsName(client *ethclient.Client, name string, alreadyChecked *EnsC return fmt.Errorf("error writing ens data for name [%v]: %w", name, err) } - logrus.WithFields(logrus.Fields{ - "name": name, - "address": addr, - "expires": expires, - "reverseName": reverseName, - }).Infof("validated ens name") + // logrus.WithFields(logrus.Fields{ + // "name": name, + // "address": addr, + // "expires": expires, + // "reverseName": reverseName, + // }).Infof("validated ens name") return nil }