Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate field validation not working when fields are in reusable blocks (Allows multiple email / etc...) #118

Open
thomasplevy opened this issue Jun 18, 2021 · 1 comment
Open

Duplicate field validation not working when fields are in reusable blocks (Allows multiple email / etc...) #118

thomasplevy opened this issue Jun 18, 2021 · 1 comment
Labels
Severity: Normal Type: Enhancement Improvements existing features or code

Comments

@thomasplevy
Copy link
Contributor

See WordPress/gutenberg#32863

Reproduction within LifterLMS using the reusable blocks created by LLMS (Email Address (Reusable) for example)

This is "resolved" via 165c053

I'm going to leave this issue open to track in case a better solution comes out of the Gutenberg issue above
@thomasplevy thomasplevy transferred this issue from gocodebox/lifterlms Jun 22, 2021
@thomasplevy thomasplevy added Severity: Normal Type: Enhancement Improvements existing features or code labels Jun 22, 2021
@thomasplevy thomasplevy changed the title Duplicate field validation not working when fields are in reusable blocks (Allows multiple email / etc... maybe a WP core issue? Duplicate field validation not working when fields are in reusable blocks (Allows multiple email / etc...) Jun 22, 2021
@thomasplevy
Copy link
Contributor Author

The fix (165c053) is causing #125 and #121

I'm going to revert this change as the ability to add the same field twice is less offensive then the two issues being caused by the attempt to prevent this issue.

This was referenced Jul 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Severity: Normal Type: Enhancement Improvements existing features or code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasplevy