Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wont compile anymore #3

Open
0xd5dc opened this issue Oct 1, 2020 · 2 comments
Open

wont compile anymore #3

0xd5dc opened this issue Oct 1, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@0xd5dc
Copy link

0xd5dc commented Oct 1, 2020

`# github.com/gocolly/redisstorage
..\github.com\gocolly\redisstorage\redisstorage.go:43:25: not enough arguments in call to s.Client.cmdable.Ping
have ()
want (context.Context)
..\github.com\gocolly\redisstorage\redisstorage.go:54:20: not enough arguments in call to s.Client.cmdable.Keys
have (string)
want (context.Context, string)
..\github.com\gocolly\redisstorage\redisstorage.go:59:21: not enough arguments in call to s.Client.cmdable.Keys
have (string)
want (context.Context, string)
..\github.com\gocolly\redisstorage\redisstorage.go:66:21: not enough arguments in call to s.Client.cmdable.Del
have ([]string...)
want (context.Context, ...string)
..\github.com\gocolly\redisstorage\redisstorage.go:71:21: not enough arguments in call to s.Client.cmdable.Set
have (string, string, time.Duration)
want (context.Context, string, interface {}, time.Duration)
..\github.com\gocolly\redisstorage\redisstorage.go:76:24: not enough arguments in call to s.Client.cmdable.Get
have (string)
want (context.Context, string)
..\github.com\gocolly\redisstorage\redisstorage.go:96:21: not enough arguments in call to s.Client.cmdable.Set
have (string, string, number)
want (context.Context, string, interface {}, time.Duration)
..\github.com\gocolly\redisstorage\redisstorage.go:109:33: not enough arguments in call to s.Client.cmdable.Get
have (string)
want (context.Context, string)
..\github.com\gocolly\redisstorage\redisstorage.go:123:36: cannot use s.getQueueID() (type string) as type context.Context in argument to s.Client.cmdable.RPush:
string does not implement context.Context (missing Deadline method)
..\github.com\gocolly\redisstorage\redisstorage.go:123:36: cannot use r (type []byte) as type string in argument to s.Client.cmdable.RPush
..\github.com\gocolly\redisstorage\redisstorage.go:123:36: too many errors

Compilation finished with exit code 2
`

@asciimoo
Copy link
Member

asciimoo commented Oct 9, 2020

Thanks for the report. Seems like redis client has changed over time. Could you work on the fix?

@asciimoo asciimoo added the bug Something isn't working label Oct 9, 2020
@wtwver
Copy link

wtwver commented Mar 7, 2021

A quick fix could be restore to go-redis in 2018. It works fine for me. Appreciate if it could be added to README.

go get github.com/gocolly/redisstorage
cd ~/go/src/github.com/go-redis/redis
git checkout tags/v6.14.2

go run yourcode.go

Reference:
https://stackoverflow.com/questions/24855081/how-do-i-import-a-specific-version-of-a-package-using-go-get
https://github.com/go-redis/redis/releases/tag/v6.14.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants