Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE - Consider clearer loader names #238

Open
kquerna opened this issue Jan 4, 2021 · 0 comments
Open

SPIKE - Consider clearer loader names #238

kquerna opened this issue Jan 4, 2021 · 0 comments
Labels
SPIKE Further investigation is required
Milestone

Comments

@kquerna
Copy link
Contributor

kquerna commented Jan 4, 2021

Description

Currently, we use LocaleRequired in our component, HOC, and hook to load translated/localized files. The current name can yield a bit of confusion, since you are not loading a locale, but rather a localized message file. Technically, locale is required, which determines which version of the translated file to load, but the purpose of the components is to specify which translated file.

So, instead of withLocaleRequired, should we change these to be withTranslation, or withLocalizedFile, or withLocaleMessages?

Package(s): @gasket/react-intl

AC:

  • Vet this question with current users and document
  • Proposal for next steps if any.
@kquerna kquerna added this to the v7.0 milestone Jan 4, 2021
@kquerna kquerna added the SPIKE Further investigation is required label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPIKE Further investigation is required
Projects
None yet
Development

No branches or pull requests

1 participant