Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding and showing projects displayed on my My StaffPlan and /people/# views #437

Open
ericbenwa opened this issue Dec 6, 2024 · 6 comments
Assignees

Comments

@ericbenwa
Copy link
Member

ericbenwa commented Dec 6, 2024

New functionality.
This has nothing to do with archiving – different topic.

Purpose for the functionality:
I completed a project and no longer want it to display on My StaffPlan as it's no longer relevant to me... and I don't want to visually distract from the other projects I'm focused on... aka clean up my view to the important/current projects.
...

Auth'd user can hide/show projects they are connected to from displaying on their My StaffPlan.
Hiding a project from My StaffPlan has no impact on anyone else's view of that project.

Hiding a project from My StaffPlan will not hide hours from the totals in the top (bar chart).
Those hours from hidden projects will be summarized at the bottom so people can still have transparency on all hours contributing to the total.

Hiding a project from My StaffPlan will not remove me from that project.
When viewing that individual project, I can still see me in the list of people – and there will be an icon+text tag disclosing that its been hidden from My StaffPlan which will be a link to unhide it from MSP.

I cannot hide (or unhide) a project from someone else's My StaffPlan.
But if someone else has hidden projects, I can click the link at the bottom to display their hidden projects.

The default should be to hide.
But if I change to show, that choice should persist for my session.
So if I navigate away and back to My StaffPlan, I still see w/e choice I've made.

If I show these projects, they should display at the bottom of the list (similar to how we are handling showing archived projects on the Projects screen).

Extra credit: If a project has been hidden from a My StaffPlan... and you or someone else edits your future hours, then the hidden project flips to being not hidden / now shown back in that persons My StaffPlan.

See design for more details.
Might be helpful to jump on a call to walk through it (since I haven't typed up all the details here) before any engineering begins.
Let me know!

Hide MSP Projects

@zhukovdigital
Copy link
Collaborator

@fermion Perhaps we need to add new functionality to the backend first? Or is there already something for this task?

@fermion
Copy link
Collaborator

fermion commented Jan 3, 2025

@zhukovdigital yep, agreed that what we currently have for metadata for an assignment doesn't really capture this adequately. Let me think about how this might be modeled on the backend.

@ericbenwa re: prioritization, how important is this?

@ericbenwa
Copy link
Member Author

@fermion Not urgent at the moment.
Will eventually grow over time as people complete more projects and it'll become a list of projects they are no longer working / no longer need to see.
But we can hold on this for the time being.

@ericbenwa
Copy link
Member Author

@fermion I was off on assessing this tasks urgency.
Could we prioritize this for next week?

@fermion
Copy link
Collaborator

fermion commented Jan 6, 2025

@fermion I was off on assessing this tasks urgency. Could we prioritize this for next week?

Too late, you already deprioritized it. No take backsies!

puts on professional hat 🎩

Some questions first:

Hiding a project from My StaffPlan will not hide hours from the totals in the top (bar chart).

This feels like it will be an endless source of confusion unless we think about communicating clearly in the UI where the hours that aren't seen are coming from. Maybe it's moot since this is likely to be used in the scenario where a project is still active, but I'm not a part of it any longer. Admittedly I did skim this quickly so forgive me if you'd addressed it.

The default should be to hide.
But if I change to show, that choice should persist for my session.
So if I navigate away and back to My StaffPlan, I still see w/e choice I've made.

I'm reading this as "if I've hidden an assignment from My StaffPlan that I then decide to unhide, then it should stay unhidden until I hide it again". Is that what you're saying?

Extra credit: If a project has been hidden from a My StaffPlan... and you or someone else edits your future hours, then the hidden project flips to being not hidden / now shown back in that persons My StaffPlan.

Challenge accepted!

@ericbenwa
Copy link
Member Author

@fermion I was off on assessing this tasks urgency. Could we prioritize this for next week?

Too late, you already deprioritized it. No take backsies!

puts on professional hat 🎩

Some questions first:

Hiding a project from My StaffPlan will not hide hours from the totals in the top (bar chart).

This feels like it will be an endless source of confusion unless we think about communicating clearly in the UI where the hours that aren't seen are coming from. Maybe it's moot since this is likely to be used in the scenario where a project is still active, but I'm not a part of it any longer. Admittedly I did skim this quickly so forgive me if you'd addressed it.

Yea, that wasn't being done well.
Just revised the design and reattached to the original post.
The updated design now displays those total hours from hidden projects at the bottom.
So all hours are accounted for visually that contribute to the total hours at the top with the bars – no hidden hours.

The default should be to hide.
But if I change to show, that choice should persist for my session.
So if I navigate away and back to My StaffPlan, I still see w/e choice I've made.

I'm reading this as "if I've hidden an assignment from My StaffPlan that I then decide to unhide, then it should stay unhidden until I hide it again". Is that what you're saying?

No... my comment is confusing.
Thinking about how we handle the state of toggling the show/hide projects link at the bottom.
If I choose to show hidden projects and navigate away and back, how should we handle that state (reset it back to hidden, still show them)?
I think we can borrow the same behavior we're doing with show archived projects – we keep w/e state the user chooses as they navigate away and back... but if they refresh, then we reset it back to hiding archived projects.

Extra credit: If a project has been hidden from a My StaffPlan... and you or someone else edits your future hours, then the hidden project flips to being not hidden / now shown back in that persons My StaffPlan.

Challenge accepted!

@ericbenwa ericbenwa changed the title Hiding and showing projects displayed on my My StaffPlan Hiding and showing projects displayed on my My StaffPlan and /people/# views Jan 13, 2025
@zhukovdigital zhukovdigital self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants