Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes hitting Enter with 0 hours doesn't submit weekly hours #465

Open
ericbenwa opened this issue Dec 12, 2024 · 2 comments
Open

Sometimes hitting Enter with 0 hours doesn't submit weekly hours #465

ericbenwa opened this issue Dec 12, 2024 · 2 comments
Assignees

Comments

@ericbenwa
Copy link
Member

ericbenwa commented Dec 12, 2024

Sometimes the first enter doesn't work when entering 0.
If it doesn't work on first Enter, it'll work on second Enter.

To reproduce:

  • go to an individual project
  • enter some hours (>0) into the proposed/sign row for a person
  • remove focus from that input field
  • go back into that input field you just edited and now type 0 and hit Enter
  • ...that Enter should not work...
  • ... now hit Enter again and it should work for committing the 0 hours and revising the UI
enter-twice.mov
@zhukovdigital
Copy link
Collaborator

@fermion I think it occurs because of the way the backend works with “0” values and an empty string.

@fermion
Copy link
Collaborator

fermion commented Jan 13, 2025

@fermion I think it occurs because of the way the backend works with “0” values and an empty string.

@zhukovdigital let me take a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants