Updated lint version and a bunch of false positives started showing up.

[afa7789]

1.45.2 to Latest 1.53

this was the error that made me want to upgrade the golang=lint to try and solve it:

panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

After I updated my golang-lint version I started getting a bunch of false positives.
I had to update because my team needed the new go version for a telemetry package to debug an issue.

Is there a better workaround then updating my lint? ( I would like to solve the rules/rules error from before instead of updating )

Errors that I did not have before, some of the unused errors by the way are wrong I'm using the variable.

api/files/network.go:13:2: import 'github.com/99designs/gqlgen/graphql' is not allowed from list 'Main' (depguard)
	"github.com/99designs/gqlgen/graphql"
	^
api/files/network.go:18:2: import 'github.com/withtally/tally/api/graph/model' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/graph/model"
	^
api/files/storage.go:7:2: import 'cloud.google.com/go/storage' is not allowed from list 'Main' (depguard)
	"cloud.google.com/go/storage"
	^
api/files/storage.go:8:2: import 'github.com/withtally/tally/api/graph/model' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/graph/model"
	^
api/middleware/dataloaders/account.go:9:2: import 'entgo.io/ent/dialect' is not allowed from list 'Main' (depguard)
	"entgo.io/ent/dialect"
	^
api/middleware/dataloaders/account.go:10:2: import 'entgo.io/ent/dialect/sql' is not allowed from list 'Main' (depguard)
	entsql "entgo.io/ent/dialect/sql"
	^
api/middleware/dataloaders/account.go:11:2: import 'github.com/ChainAgnostic/go-caip' is not allowed from list 'Main' (depguard)
	"github.com/ChainAgnostic/go-caip"
	^
api/middleware/dataloaders/account.go:12:2: import 'github.com/graph-gophers/dataloader' is not allowed from list 'Main' (depguard)
	"github.com/graph-gophers/dataloader"
	^
api/middleware/dataloaders/account.go:13:2: import 'github.com/withtally/tally/api/ent' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent"
	^
api/middleware/dataloaders/account.go:14:2: import 'github.com/withtally/tally/api/ent/account' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent/account"
	^
api/middleware/dataloaders/account.go:15:2: import 'github.com/withtally/tally/api/ent/schema' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent/schema"
	^
api/middleware/dataloaders/account.go:16:2: import 'github.com/withtally/tally/base' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base"
	^
api/middleware/dataloaders/cache.go:8:2: import 'github.com/graph-gophers/dataloader' is not allowed from list 'Main' (depguard)
	"github.com/graph-gophers/dataloader"
	^
api/middleware/dataloaders/cache.go:9:2: import 'github.com/withtally/tally/base' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base"
	^
api/middleware/dataloaders/dataloaders.go:9:2: import 'github.com/graph-gophers/dataloader' is not allowed from list 'Main' (depguard)
	"github.com/graph-gophers/dataloader"
	^
api/middleware/dataloaders/dataloaders.go:10:2: import 'github.com/withtally/tally/api/ent' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent"
	^
api/middleware/dataloaders/dataloaders.go:11:2: import 'github.com/withtally/tally/api/gnosis' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/gnosis"
	^
api/middleware/dataloaders/dataloaders.go:12:2: import 'github.com/withtally/tally/etl/ent' is not allowed from list 'Main' (depguard)
	etlent "github.com/withtally/tally/etl/ent"
	^
api/middleware/dataloaders/governance.go:7:2: import 'github.com/ChainAgnostic/go-caip' is not allowed from list 'Main' (depguard)
	"github.com/ChainAgnostic/go-caip"
	^
api/middleware/dataloaders/governance.go:9:2: import 'github.com/withtally/tally/api/ent' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent"
	^
api/middleware/dataloaders/governance.go:10:2: import 'github.com/withtally/tally/api/ent/governance' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/api/ent/governance"
	^
api/middleware/dataloaders/governance.go:11:2: import 'github.com/withtally/tally/base' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base"
	^
api/middleware/dataloaders/oc_account.go:8:2: import 'github.com/ChainAgnostic/go-caip' is not allowed from list 'Main' (depguard)
	"github.com/ChainAgnostic/go-caip"
	^
api/middleware/dataloaders/oc_account.go:11:2: import 'github.com/withtally/tally/etl/ent' is not allowed from list 'Main' (depguard)
	etlent "github.com/withtally/tally/etl/ent"
	^
api/middleware/dataloaders/oc_account.go:12:2: import 'github.com/withtally/tally/etl/ent/account' is not allowed from list 'Main' (depguard)
	etlaccount "github.com/withtally/tally/etl/ent/account"
	^
api/middleware/dataloaders/oc_delegate_count.go:10:2: import 'github.com/withtally/tally/base/types' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base/types"
	^
api/middleware/dataloaders/oc_delegate_count.go:11:2: import 'github.com/withtally/tally/etl/ent' is not allowed from list 'Main' (depguard)
	etlent "github.com/withtally/tally/etl/ent"
	^
api/middleware/dataloaders/oc_delegate_count.go:12:2: import 'github.com/withtally/tally/etl/ent/tokenaccount' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/tokenaccount"
	^
api/middleware/dataloaders/oc_delegation_out.go:9:2: import 'entgo.io/ent/dialect' is not allowed from list 'Main' (depguard)
	"entgo.io/ent/dialect"
	^
api/middleware/dataloaders/oc_delegation_out.go:10:2: import 'entgo.io/ent/dialect/sql' is not allowed from list 'Main' (depguard)
	entsql "entgo.io/ent/dialect/sql"
	^
api/middleware/dataloaders/oc_delegation_out.go:14:2: import 'github.com/withtally/tally/base/types' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base/types"
	^
api/middleware/dataloaders/oc_delegation_out.go:15:2: import 'github.com/withtally/tally/etl/ent/block' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/block"
	^
api/middleware/dataloaders/oc_delegation_out.go:16:2: import 'github.com/withtally/tally/etl/ent/delegationchange' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/delegationchange"
	^
api/middleware/dataloaders/oc_delegation_out.go:17:2: import 'github.com/withtally/tally/etl/ent/migrate' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/migrate"
	^
api/middleware/dataloaders/oc_delegation_out.go:18:2: import 'github.com/withtally/tally/etl/ent/schema' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/schema"
	^
api/middleware/dataloaders/oc_delegation_out.go:19:2: import 'github.com/withtally/tally/etl/ent/tokenaccount' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/tokenaccount"
	^
api/middleware/dataloaders/oc_delegation_out.go:20:2: import 'github.com/withtally/tally/etl/proto' is not allowed from list 'Main' (depguard)
	pb "github.com/withtally/tally/etl/proto"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:8:2: import 'entgo.io/ent/dialect' is not allowed from list 'Main' (depguard)
	"entgo.io/ent/dialect"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:9:2: import 'entgo.io/ent/dialect/sql' is not allowed from list 'Main' (depguard)
	entsql "entgo.io/ent/dialect/sql"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:10:2: import 'github.com/ethereum/go-ethereum/common' is not allowed from list 'Main' (depguard)
	"github.com/ethereum/go-ethereum/common"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:13:2: import 'github.com/withtally/tally/base/types' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/base/types"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:15:2: import 'github.com/withtally/tally/etl/ent/block' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/block"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:16:2: import 'github.com/withtally/tally/etl/ent/delegationchange' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/delegationchange"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:17:2: import 'github.com/withtally/tally/etl/ent/migrate' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/migrate"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:18:2: import 'github.com/withtally/tally/etl/ent/tokenaccount' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/tokenaccount"
	^
api/middleware/dataloaders/oc_delegations_in_weight_sum.go:19:2: import 'github.com/withtally/tally/etl/proto' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/proto"
	^
api/middleware/dataloaders/oc_owned_safes.go:11:2: import 'github.com/withtally/tally/etl/proto' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/proto"
	^
api/middleware/dataloaders/oc_proposal_with_edges.go:7:2: import 'github.com/ethereum/go-ethereum/common' is not allowed from list 'Main' (depguard)
	"github.com/ethereum/go-ethereum/common"
	^
api/middleware/dataloaders/oc_proposal_with_edges.go:11:2: import 'github.com/withtally/tally/etl/ent/proposal' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/proposal"
	^
api/middleware/dataloaders/oc_voting_power_changes.go:15:2: import 'github.com/withtally/tally/etl/ent/block' is not allowed from list 'Main' (depguard)
	"github.com/withtally/tally/etl/ent/block"
	^
api/middleware/dataloaders/oc_voting_power.go:48:35: S1025: should use String() instead of fmt.Sprintf (gosimple)
		accIDsStrs = append(accIDsStrs, fmt.Sprintf("%s", id))
		                                ^
api/middleware/dataloaders/oc_voting_power.go:63:4: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
			fmt.Sprintf("%s", strings.Join(accIDsStrs, ",")),
			^
api/middleware/dataloaders/account.go:80:19: S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
				"rtt":        time.Now().Sub(start).Milliseconds(),
				              ^
api/middleware/dataloaders/oc_account.go:51:19: S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
				"rtt":        time.Now().Sub(start).Milliseconds(),
				              ^
base/pgtest/pgtest.go:130:77: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return fmt.Errorf("waiting for connection (last connection err %v): %w", cErr, ctx.Err())
			                                                                         ^
base/pgtest/pgtest.go:8:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
runtime/build_test.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
api/tenderly/tenderly.go:8:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
api/graph/helpers.go:273:35: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
		err = fmt.Errorf("%w: %v", err, rerr)
		                                ^
etl/analytics/analytics_test.go:20:7: type `fields` is unused (unused)
	type fields struct {
	     ^
base/constants.go:4:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
	NaturalKeySplitChar string = "|"
	^
base/constants.go:13:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
	Unspecified          string = "unspecified"
	^
base/flags.go:66:54: SA1019: secretmanagerpb.AccessSecretVersionRequest is deprecated: Please use types in: cloud.google.com/go/secretmanager/apiv1/secretmanagerpb (staticcheck)
	result, err := smClient().AccessSecretVersion(ctx, &secretmanagerpb.AccessSecretVersionRequest{Name: name})
	                                                    ^
base/flags.go:14:18: SA1019: "google.golang.org/genproto/googleapis/cloud/secretmanager/v1" is deprecated: Please use types in: cloud.google.com/go/secretmanager/apiv1/secretmanagerpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details. (staticcheck)
	secretmanagerpb "google.golang.org/genproto/googleapis/cloud/secretmanager/v1"
	                ^
base/tracing.go:11:2: SA1019: "go.opentelemetry.io/otel/exporters/jaeger" is deprecated: This module is no longer supported. OpenTelemetry dropped support for Jaeger exporter in July 2023. Jaeger officially accepts and recommends using OTLP. Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp] or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead. (staticcheck)
	"go.opentelemetry.io/otel/exporters/jaeger"
	^
etl/ent/token_account_ext.go:51:34: S1025: should use String() instead of fmt.Sprintf (gosimple)
			log.Info().Str("FilterField", fmt.Sprintf("%s", *filter.Field)).Msg("DelegateFilter with Field")
			                              ^
etl/ent/token_account_ext.go:60:30: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
			log.Info().Str("IssueID", fmt.Sprintf("%s", stringIssue)).Msg("DelegateFilter with Issue")
			                          ^
etl/processors/ensregistry.go:47:2: var `setName` is unused (unused)
	setName         abi.ABI
	^
etl/processors/tokendistributor.go:21:2: field `assetID` is unused (unused)
	assetID caip.EVMAssetID
	^
etl/processors/securitycouncilmemberelectiongovernor_test.go:50:2: SA4006: this value of `txn` is never used (staticcheck)
	address, txn, c, err := bindings.DeployFakeSecurityCouncilMemberElectionGovernor(auth, eth)
	^
etl/processors/securitycouncilnomineeelectiongovernor_test.go:48:2: SA4006: this value of `txn` is never used (staticcheck)
	address, txn, c, err := bindings.DeployFakeSecurityCouncilNomineeElectionGovernor(auth, eth)
	^
etl/processors/tokendistributor_test.go:48:2: SA4006: this value of `txn` is never used (staticcheck)
	address, txn, c, err := bindings.DeployFakeTokenDistributor(auth, eth)
	^
api/middleware/api_keys.go:129:2: SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck)
	rand.Seed(time.Now().UnixNano())
	^
api/tallyproposal/tallyproposal.go:130: File is not `gofmt`-ed with `-s` (gofmt)
	hashProposal returns the equivalent of OpenZeppelin's `Governor.hashProposal` as defined:

[ldez]

Hello,

the default configuration of depguard has changed: you have to provide a configuration or disable the linter.
ex:

  depguard:
    rules:
      main:
        deny:
          - pkg: "github.com/instana/testify"
            desc: not allowed
          - pkg: "github.com/pkg/errors"
            desc: Should be replaced by standard lib errors package

Also:

• check your GOROOT (should be different than your GOPATH).
• check your Go version (should be go1.20 or go1.21)

[afa7789]

I have to provide who I want to deny ? or who I want to allow ?

[ldez]

it depends on your use case.

https://golangci-lint.run/usage/linters/#depguard

[afa7789]

Yeah but I have to put all packages I'm using on it, this is stupid.
the depguard on previous version did not ask me to do it.
I don't get it.

[ldez]

Yeah but I have to put all packages I'm using on it

No at all, please read my previous example or just copy-paste my example, and read the documentation.