Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize images to 768x768px in GenerativeAIMultimodalSample #75

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Dec 15, 2023

Resizes images to fit within 768x768 pixels while maintaining the same aspect ratio. This size was chosen to allow multiple images to be sent within the maximum size limit (4MB at time of writing). See https://googledevai.devsite.corp.google.com/docs/gemini_api_overview#image_requirements for more details.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 15, 2023
@andrewheard andrewheard enabled auto-merge (squash) December 15, 2023 21:58
@andrewheard andrewheard disabled auto-merge December 15, 2023 22:15
Copy link
Collaborator

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment that might have cascading changes.

@andrewheard
Copy link
Collaborator Author

@peterfriese Please let me know if you have any concerns with these changes.

Copy link
Collaborator

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small suggestion.

@andrewheard andrewheard merged commit 4ab8724 into main Jan 11, 2024
8 checks passed
@andrewheard andrewheard deleted the ah/image-resizing branch January 11, 2024 19:36
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants