-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize images to 768x768px in GenerativeAIMultimodalSample #75
Conversation
...les/GenerativeAISample/GenerativeAIMultimodalSample/ViewModels/PhotoReasoningViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment that might have cascading changes.
...les/GenerativeAISample/GenerativeAIMultimodalSample/ViewModels/PhotoReasoningViewModel.swift
Outdated
Show resolved
Hide resolved
@peterfriese Please let me know if you have any concerns with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small suggestion.
Resizes images to fit within 768x768 pixels while maintaining the same aspect ratio. This size was chosen to allow multiple images to be sent within the maximum size limit (4MB at time of writing). See https://googledevai.devsite.corp.google.com/docs/gemini_api_overview#image_requirements for more details.