Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Consider adopting Bazel Closure Rules #67

Open
jart opened this issue Jun 7, 2016 · 2 comments
Open

Consider adopting Bazel Closure Rules #67

jart opened this issue Jun 7, 2016 · 2 comments

Comments

@jart
Copy link

jart commented Jun 7, 2016

Greetings. I notice you have Closure Library unit tests in your project, e.g. bar_data_test.js. Internally you use Blaze rules to test this project. But externally, you have no way of running these tests. This puts your open source contributors at a disadvantage, because they have no way of testing their contributions. They have to ask a Googler to patch and run their change for them.

Consider adopting Bazel with Closure Rules and Go Rules. You will be able to have the same build system externally as you use internally. All your tests, will be able to run on Travis CI too, including browser tests.

Closure Rules offers another advantage: no more GenJsDeps. The Closure Rules behave basically the same as Java rules. It's so much nicer.

Let me know if there's anything I can do to help.

@chenqili
Copy link

Hello, may I ask you to teach me how to read the data correctly it

@jart
Copy link
Author

jart commented Jun 13, 2016

Hmm?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants