You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Greetings. I notice you have Closure Library unit tests in your project, e.g. bar_data_test.js. Internally you use Blaze rules to test this project. But externally, you have no way of running these tests. This puts your open source contributors at a disadvantage, because they have no way of testing their contributions. They have to ask a Googler to patch and run their change for them.
Consider adopting Bazel with Closure Rules and Go Rules. You will be able to have the same build system externally as you use internally. All your tests, will be able to run on Travis CI too, including browser tests.
Closure Rules offers another advantage: no more GenJsDeps. The Closure Rules behave basically the same as Java rules. It's so much nicer.
Let me know if there's anything I can do to help.
The text was updated successfully, but these errors were encountered:
Greetings. I notice you have Closure Library unit tests in your project, e.g. bar_data_test.js. Internally you use Blaze rules to test this project. But externally, you have no way of running these tests. This puts your open source contributors at a disadvantage, because they have no way of testing their contributions. They have to ask a Googler to patch and run their change for them.
Consider adopting Bazel with Closure Rules and Go Rules. You will be able to have the same build system externally as you use internally. All your tests, will be able to run on Travis CI too, including browser tests.
Closure Rules offers another advantage: no more GenJsDeps. The Closure Rules behave basically the same as Java rules. It's so much nicer.
Let me know if there's anything I can do to help.
The text was updated successfully, but these errors were encountered: