Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug for frame_skip at AtariPreprocessing #177

Open
alirahkay opened this issue May 12, 2021 · 0 comments
Open

Minor bug for frame_skip at AtariPreprocessing #177

alirahkay opened this issue May 12, 2021 · 0 comments

Comments

@alirahkay
Copy link

When setting frame_skip=1 in the AtariPreprocessing, we will always have t=1 in the step function (line 475 of atari_lib.py). And so, self.screen_buffer[0] never gets updated.
Now considering the _pool_and_resize when frame_skip is one, transformed_image is exactly the resized self.screen_buffer[0], and so, it will never change in the entire episode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant