Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REFLECT padding to convolution layer #4553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarlinpe
Copy link

What does this PR do?

Add a REFLECT padding mode to the linen covolution layer.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@sarlinpe sarlinpe force-pushed the sarlinpe/conv-padding-reflect branch 2 times, most recently from 143a814 to 2537c77 Compare February 19, 2025 15:44
@sarlinpe
Copy link
Author

@cgarciae It would be great to receive your review, thank you!

@sarlinpe sarlinpe force-pushed the sarlinpe/conv-padding-reflect branch from 2537c77 to 87b027f Compare February 21, 2025 11:10
@cgarciae
Copy link
Collaborator

Thanks @sarlinpe for doing this! Looks good.
Can you make the same update for nnx.Conv? We try to keep them in sync.

@sarlinpe sarlinpe force-pushed the sarlinpe/conv-padding-reflect branch from 87b027f to d2abe62 Compare February 23, 2025 19:05
@sarlinpe
Copy link
Author

Done, PTAL.

@sarlinpe sarlinpe force-pushed the sarlinpe/conv-padding-reflect branch from d2abe62 to d552d4b Compare February 23, 2025 19:08
@sarlinpe
Copy link
Author

@cgarciae Friendly ping, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants