Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-2816] - Update exception type in JsonDeserializer to JsonSyntaxException #2820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shershah03
Copy link

@Shershah03 Shershah03 commented Mar 5, 2025

…xException

Purpose

Closes #2816

Description

As mentioned in #2816 , If _com.google.gson.Gson.fromJson(String, Class<User>)_ throws JsonSyntaxException but in case any one imeplements custom JsonDeserializer then it by default throws JsonParseException.
For any com.google.gson.Gson.fromJson(String, Class<User>) calls , its normal to catch JsonSyntaxException, But in case use of JsonDeserializer, this exception will not be caught.
Ideally fromJson and JsonDeserializer interface should throw same exceptions.

Checklist

  • New code follows the Google Java Style Guide
    This is automatically checked by mvn verify, but can also be checked on its own using mvn spotless:check.
    Style violations can be fixed using mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method fromJson throws JsonParseException instead of declared JsonSyntaxException
1 participant