Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Missing parentheses when multiplying with a negative number #240

Open
Stumblefeet opened this issue Aug 23, 2018 · 5 comments
Open

Missing parentheses when multiplying with a negative number #240

Stumblefeet opened this issue Aug 23, 2018 · 5 comments

Comments

@Stumblefeet
Copy link

A well-formed formula does not allow for a multiplication sign to be followed by a minus sign.

I recently tried 2-5*(3-6) and got
2-5*-3

@evykassirer
Copy link
Contributor

Thank you for noticing this an opening an issue!

I'm not actively working on mathsteps right now, but am happy to help you make a PR to update this :)

Seems like there would need to be an update to the removeUnecessaryParens function, but that could be messy and break some other functionality. Would be interesting to explore!

@Stumblefeet
Copy link
Author

Thanks.

I'm considering diving into the code and study it in depth.

Do you know if this project is still being developed, or is it dying/finished?

I'm looking for a large project to contribute to, and this seems rather nice.

@evykassirer
Copy link
Contributor

I haven't been prioritizing much time on mathsteps lately, so it is some ways dying.

However, if you take a look through the code and would like me to answer some questions or help you contribute, I'd be happy to spend some time on that :)

@ghost
Copy link

ghost commented Sep 27, 2018

@evykassirer I am personally interested in helping out. mathsteps should not die. It has tremendous value and potential ! Is there a priority list somewhere with things pending ?

@evykassirer
Copy link
Contributor

the list of open issues is a good place to look for things pending!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants