Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell test(s) for integration testing #360

Open
mtrofin opened this issue Sep 9, 2024 · 2 comments
Open

Shell test(s) for integration testing #360

mtrofin opened this issue Sep 9, 2024 · 2 comments

Comments

@mtrofin
Copy link
Collaborator

mtrofin commented Sep 9, 2024

Do we want something more formal for shell tests - we have check_license.sh but not much else, but there are cases where we'd want to test a tool (for example, PR #357 ) with e.g. saved_model_cli and then maybe a few more steps (like building a small C/C++ example, etc)

At minimum we can run such scripts from the CI, of course, but having a nice test infra for shells would help.

@boomanaiden154
Copy link
Collaborator

This was sort of the goal in #121.

@mtrofin
Copy link
Collaborator Author

mtrofin commented Sep 9, 2024

ack, but can we have a shell test framework (like are there such things - do we need one... that kind of thing. Something to know to keep running all tests even if one fails, manage scratch dirs... I'm hoping we can get something off the shelf.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants