Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigtable): Resolve flaky tests and refactor code #11354

Merged
merged 3 commits into from
Jan 8, 2025
Merged

test(bigtable): Resolve flaky tests and refactor code #11354

merged 3 commits into from
Jan 8, 2025

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Dec 28, 2024

  1. Flaky test: bigtable: TestIntegration_Aggregates failed #11183
=== RUN   TestIntegration_Aggregates
    integration_test.go:4300: Running test against production
    retry.go:44: FAILED after 3 attempts:
        integration_test.go:4375: rpc error: code = Unavailable desc = The service is currently unavailable.
    integration_test.go:4331: Error creating table: rpc error: code = Unavailable desc = The service is currently unavailable.
    integration_test.go:331: rpc error: code = Unavailable desc = The service is currently unavailable.
--- FAIL: TestIntegration_Aggregates (30.33s)

Fix: Increase number of retries and add exponential backoff

  1. Flaky test: bigtable: TestIntegration_UpdateFamilyValueType failed #11182
=== RUN   TestIntegration_UpdateFamilyValueType
    integration_test.go:4300: Running test against production
    integration_test.go:314: Failed to update value type of family new_family with current type : rpc error: code = Unavailable desc = The service is currently unavailable.
    integration_test.go:4358: DeleteTable got error rpc error: code = Unavailable desc = The service is currently unavailable.
--- FAIL: TestIntegration_UpdateFamilyValueType (99.82s)

Fix: Retry update

  1. Flaky test: bigtable: TestIntegration_AdminCreateInstance failed #11271
=== RUN   TestIntegration_AdminCreateInstance
    integration_test.go:2481: CreateInstance: rpc error: code = AlreadyExists desc = Instance bt-it-17338853670 already exists.
--- FAIL: TestIntegration_AdminCreateInstance (0.39s)

Fix: Retry create instance after delete

  1. Flaky test: bigtable: TestIntegration_AdminEncryptionInfo failed #11268
=== RUN   TestIntegration_AdminEncryptionInfo
    integration_test.go:2610: CreateInstance: rpc error: code = AlreadyExists desc = Instance bt-it-173388536701 already exists.
--- FAIL: TestIntegration_AdminEncryptionInfo (0.44s)

Fix: Retry create instance after delete

@bhshkh bhshkh requested review from a team as code owners December 28, 2024 20:56
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 28, 2024
This was linked to issues Dec 28, 2024
bigtable: TestIntegration_Aggregates failed #11183
Closed
bigtable: TestIntegration_UpdateFamilyValueType failed #11182
Closed
bigtable: TestIntegration_AdminCreateInstance failed #11271
Closed
bigtable: TestIntegration_AdminEncryptionInfo failed #11268
Open
@bhshkh bhshkh enabled auto-merge (squash) January 8, 2025 02:28
@bhshkh bhshkh merged commit aa48838 into googleapis:main Jan 8, 2025
8 of 10 checks passed
@bhshkh bhshkh deleted the test/cbt-tests-01 branch January 8, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
2 participants
@bhshkh @gkevinzheng