From e27a03a23bcd7dd036dedf89a1bceaa0a848ddf0 Mon Sep 17 00:00:00 2001 From: Rodrigo Queiro Date: Wed, 9 Mar 2022 14:40:35 +0100 Subject: [PATCH] Increase timeout in apps test I'm not sure why, but it seems it takes sometimes ~one minute to delete the old job, even though the underlying pod just runs `false` and should terminate immediately. After bumping the timeout, the test passed 25 times in a row, whereas before it failed on the second attempt. Fixes b/223331353. Change-Id: Ice1760a9b7d51f47a3d0e052b62f2aa878c79618 GitOrigin-RevId: 86eb62aee3b09498c85d3cb13fae599c80bed02b --- src/go/tests/apps/BUILD.bazel | 2 -- src/go/tests/apps/apps_test.go | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/go/tests/apps/BUILD.bazel b/src/go/tests/apps/BUILD.bazel index d77d1cc7..c899718b 100644 --- a/src/go/tests/apps/BUILD.bazel +++ b/src/go/tests/apps/BUILD.bazel @@ -10,8 +10,6 @@ go_test( "//src/go/cmd/synk", "@kubernetes_helm//:helm", ], - # TODO(b/223331353): fix flake - flaky = True, rundir = ".", tags = [ "requires-access-token", diff --git a/src/go/tests/apps/apps_test.go b/src/go/tests/apps/apps_test.go index 79c6902c..bb525b70 100644 --- a/src/go/tests/apps/apps_test.go +++ b/src/go/tests/apps/apps_test.go @@ -346,7 +346,7 @@ func testUpdateChartAssignment_WithFixedJob_BecomesReady(t *testing.T, f *kubete if err := backoff.Retry( f.ChartAssignmentHasStatus(&ca, crcapps.ChartAssignmentPhaseReady), - backoff.WithMaxRetries(backoff.NewConstantBackOff(time.Second), 60), + backoff.WithMaxRetries(backoff.NewConstantBackOff(3*time.Second), 60), ); err != nil { t.Fatalf("wait for chart assignment to go from Settled to Ready: %s", err) }