Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Locking while taking a snapshot #238

Open
jvshahid opened this issue Oct 8, 2014 · 8 comments
Open

Locking while taking a snapshot #238

jvshahid opened this issue Oct 8, 2014 · 8 comments

Comments

@jvshahid
Copy link
Contributor

jvshahid commented Oct 8, 2014

We have come across a bug in influxdata/influxdb#1006 which I think is caused by the lack of locking while taking a snapshot. There's a todo that points to this limitation, but I think this is a serious bug that should be addressed immediately. The line in question is https://github.com/goraft/raft/blob/master/server.go#L1188

@jvshahid
Copy link
Contributor Author

ping, can someone confirm this bug ?

@mre
Copy link

mre commented Oct 27, 2014

+1 Can we help with this?

@mre
Copy link

mre commented Oct 31, 2014

So as far as I can see, this library is currently unmaintained, right?

@benbjohnson
Copy link
Contributor

@mre Yes, the original devs on the project have either built newer implementations or are not using the library anymore. @philips is adding a shield to the README to notify users that the library is unmaintained and new maintainers are welcome.

#241

@mre
Copy link

mre commented Nov 3, 2014

@benbjohnson, thanks for the info. @jvshahid: Is team around InfluxDB planning to maintain this or are you looking for alternatives?

@benbjohnson
Copy link
Contributor

@mre I'm working with InfluxDB on a high performance version of raft to stream all data through. After that's finished, InfluxDB won't have a go-raft dependency.

@mre
Copy link

mre commented Nov 3, 2014

@benbjohnson Very nice. I could help you with testing if you like.

@philips
Copy link
Member

philips commented Nov 3, 2014

@mre The etcd team's library is at http://godoc.org/github.com/coreos/etcd/raft and it is also used by http://godoc.org/github.com/cockroachdb/cockroach/multiraft if you are looking at options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants