-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FromScalar makes no sense with mask #7
Comments
From @kabaka0 on July 3, 2017 23:20 My reasoning was that there could be cases in which a scalar is masked, such as, say, a reduction operation from a masked array (say all elements invalid) that results in an invalid scalar. I opted as a result to include the option of creating a scalar with a mask, given that it is not forbidden. I believe that numpy also supports masked 'scalars' (numpy/numpy#4332) |
From @kabaka0 on July 3, 2017 23:26 Also in the case you quote, |
OK. Thanks. Very helpful. Can you craft a documentation for this? Thanks |
From @kabaka0 on July 3, 2017 23:35 Sure, I will do! On Jul 3, 2017 7:34 PM, "Chewxy" [email protected] wrote:
|
(btw, just send a PR, I'll merge your documentation before #127 |
From @chewxy on July 3, 2017 23:12
A scalar value should not be masked. Is there a reason why a scalar value is maskable? @kabaka0
There are various instances where
retVal = New(FromScalar(argmaxI(t.Ints(), t.mask)))
or something similar is called, but I cannot for rhyme or reason figure out why.Copied from original issue: gorgonia/gorgonia#132
The text was updated successfully, but these errors were encountered: