Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more customizable props and enhancements #65

Open
Stringsaeed opened this issue Jul 24, 2020 · 1 comment · May be fixed by #66
Open

Add more customizable props and enhancements #65

Stringsaeed opened this issue Jul 24, 2020 · 1 comment · May be fixed by #66
Labels
enhancement New feature or request

Comments

@Stringsaeed
Copy link

Stringsaeed commented Jul 24, 2020 •
edited
Loading

Feature Request

  • Add more customizable props like tab style for bubble preset
  • Remove isRTL it's redundant because I18nmanager.forceRTL(true) is translates the view to right automatically and your code amazingly supports all views and styles for I18nmanager so you don't need to worry about this

Why it is needed

I have many use-cases for bubble tab bar but tab style is different so I couldn't achieve this.
it would be great and more effective if we can customize tabs styles or more

Awesome work 👏🏽👍🏽
@Stringsaeed Stringsaeed added the enhancement New feature or request label Jul 24, 2020
@Stringsaeed Stringsaeed changed the title Add more customizable props Add more customizable props and enhancements Jul 24, 2020
@Stringsaeed Stringsaeed linked a pull request Jul 24, 2020 that will close this issue
Open
@gorhom
Copy link
Owner

gorhom commented Jul 26, 2020

thanks @Stringsaeed for submitting this issue feature request and a pr !

Remove isRTL it's redundant because I18nmanager.forceRTL(true) is translates the view to right automatically and your code amazingly supports all views and styles for I18nmanager so you don't need to worry about this

i'll need to test to confirm it and i'll take it off if it's not needed 👍

@gorhom gorhom linked a pull request Jul 26, 2020 that will close this issue
feat: add tabStyle to bubble preset #66
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tabStyle to bubble preset Stringsaeed/react-native-animated-tabbar
2 participants
@gorhom @Stringsaeed