You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we do this, remind me to do a bunch of stress-testing on it (and specifically to keep in mind the memory usage/leaking resulting from sockets not closing correctly). The old socket was much simpler but wrecked us because it'd never completely return and close properly.
The reason why finaldata exists is because when we close because of an error or because the sendq/receiveq is overrun, I want to always make sure the final error/etc is sent indicating that problem. if you just .Send() the error then close the socket, a lot of the time in testing it wouldn't correctly output that before the socket got closed (iirc when the socket was being used in the ircd).
It's logic is very.. awkward, and the whole finaldata thing to close a socket is very weird to use.
The text was updated successfully, but these errors were encountered: