-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaking memory #82
Comments
@sbOogway can you please give me some more information?
|
how often you call it? it requires around 3m to cleanup. I assume that you have a web server or similar and you make a request. Do you wait for the program to exist or you sent multiple requests? when you start the program as it is intended to get started is the behavior the same? |
i restarted the docker container and i run it through the web interface and i get the same problem. i have waited for each job to finish. |
can you confirm the following: (1) start the app using the provided docker container in the latest version |
yes. i dont click the download button. i only start the job. why the chromium browsers run in root directory? |
this is in the docker container not in your host. docker run as root. let me check if the same happens to me (Fedora) and let you know |
ok thanks bro, appreciate it. |
ok thanks for the time. i still get the problem but i can work it around with pkill. thanks a lot |
@sbOogway you are right regarding the above. It is reproduced. It has something to do with the way the browser are cleaned up. |
@gosom if u want i can try to fix it. In which files do i have to look roughly? |
@sbOogway can you try the latest release (v1.5.1). I believe that this is fixed but I was not in the first place able to reproduce consistently. FYI: the issue most likely was that in the scrapemate repo the playwright browsers and playwright instance were not closed properly. here is the commit with the fix: |
@gosom i still get it bro |
have you tried to compile and run from your machine? This is weird, trying to reproduce again |
i have to go for the day. replying to you tomorrow. have a nice one |
Hi,
Great project bro very well done but in my setup it leaks memory. each time i run it creates a new chrome process . a simple
sudo pkill chrome
gave some memory back.The text was updated successfully, but these errors were encountered: