Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications cannot be disabled #621

Closed
1 of 3 tasks
39otrebla opened this issue Aug 19, 2022 · 3 comments
Closed
1 of 3 tasks

Notifications cannot be disabled #621

39otrebla opened this issue Aug 19, 2022 · 3 comments
Labels
wontfix Something which is not going to happen. Ever.

Comments

@39otrebla
Copy link

39otrebla commented Aug 19, 2022

Is your feature request related to a problem? Please describe.
In our Application we have both (potentially) long-running uploads and very quick ones (<1 MB). For the latter case, we don't want a Notification to appear.

Also, there are use cases where it is important that the upload continues if the app is sent to background (so it makes sense to use this library), but the upload itself is a non-core feature (or even something the user didn't start voluntarily), so it doesn't make sense to show a notification.

Describe the solution you'd like
I'd like to have a setter to enable/disable notifications on a Request instance (not globally).

Describe alternatives you've considered
An alternative would be to create a Notification Channel with the lowest priority, and then use it via UploadNotificationConfig. But in this way:

  • it would still be visible in Application Settings
  • it would still require a lot of configuration (progress StatusConfig, error StatusConfig, etc, etc) for something that no one in team would even want to show

Are you willing to implement it and maintain it?

  • Yes
  • Can implement it with a Pull Request, but not maintain it
  • No
@gotev
Copy link
Owner

gotev commented Aug 19, 2022

Google requires the notification to appear within 5 seconds after service is started, so the notification is always needed, otherwise you will have a crash.

They have posed increasing limitations and constraints on Services, to promote using WorkManager instead.

When the library was born and up to Android 8 your use case was fully supported, but afterwards, as a result of increasing limitations and constraints, the library had become best suited for user initiated uploads which may require some time and for which you want to show a progress.

@39otrebla
Copy link
Author

Are you implicitly saying that addressing #610 would unblock this feature?

@stale
Copy link

stale bot commented Oct 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Something which is not going to happen. Ever. label Oct 22, 2022
@stale stale bot closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Something which is not going to happen. Ever.
Projects
None yet
Development

No branches or pull requests

2 participants