From bd849ddc27ea89c415ba85b328032ab59644482d Mon Sep 17 00:00:00 2001
From: sabino <982190+sabino@users.noreply.github.com>
Date: Tue, 26 Nov 2024 21:42:46 -0300
Subject: [PATCH] fix: test v2 manifest instead of v12

---
 tests/fixtures/manifest-v12.json | 19 ++++++-------------
 tests/fixtures/manifest-v2.json  |  8 ++++++--
 tests/test_manifest.py           |  8 ++++----
 3 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/tests/fixtures/manifest-v12.json b/tests/fixtures/manifest-v12.json
index 996709b8..c93bcbfa 100644
--- a/tests/fixtures/manifest-v12.json
+++ b/tests/fixtures/manifest-v12.json
@@ -36,9 +36,7 @@
                 "schema": null,
                 "database": null,
                 "tags": [],
-                "meta": {
-                    "metabase.description": "This table has basic information about payments"
-                },
+                "meta": {},
                 "group": null,
                 "materialized": "table",
                 "incremental_strategy": null,
@@ -64,6 +62,7 @@
                 "access": "protected"
             },
             "tags": [],
+            "description": "This table has basic information about payments",
             "columns": {
                 "payment_id": {
                     "name": "payment_id",
@@ -87,9 +86,7 @@
                 "payment_method": {
                     "name": "payment_method",
                     "description": "",
-                    "meta": {
-                        "metabase.description": "The method used to complete a payment."
-                    },
+                    "meta": {},
                     "data_type": null,
                     "constraints": [],
                     "quote": null,
@@ -124,9 +121,7 @@
                     "tags": []
                 }
             },
-            "meta": {
-                "metabase.description": "This table has basic information about payments"
-            },
+            "meta": {},
             "group": null,
             "docs": {
                 "show": true,
@@ -198,8 +193,7 @@
                 "database": null,
                 "tags": [],
                 "meta": {
-                    "metabase.display_name": "clients",
-                    "metabase.description": "Contains customer details and derived order facts"
+                    "metabase.display_name": "clients"
                 },
                 "group": null,
                 "materialized": "table",
@@ -296,8 +290,7 @@
                 }
             },
             "meta": {
-                "metabase.display_name": "clients",
-                "metabase.description": "Contains customer details and derived order facts"
+                "metabase.display_name": "clients"
             },
             "group": null,
             "docs": {
diff --git a/tests/fixtures/manifest-v2.json b/tests/fixtures/manifest-v2.json
index ead8cc04..4bda07be 100644
--- a/tests/fixtures/manifest-v2.json
+++ b/tests/fixtures/manifest-v2.json
@@ -99,7 +99,9 @@
                 "status": {
                     "name": "status",
                     "description": "Orders can be one of the following statuses:\n\n| status         | description                                                                                                            |\n|----------------|------------------------------------------------------------------------------------------------------------------------|\n| placed         | The order has been placed but has not yet left the warehouse                                                           |\n| shipped        | The order has ben shipped to the customer and is currently in transit                                                  |\n| completed      | The order has been received by the customer                                                                            |\n| return_pending | The customer has indicated that they would like to return the order, but it has not yet been received at the warehouse |\n| returned       | The order has been returned by the customer and received at the warehouse                                              |",
-                    "meta": {},
+                    "meta": {
+                        "metabase.description": "Order status: placed, shipped, completed, return_pending, or returned."
+                    },
                     "data_type": null,
                     "quote": null,
                     "tags": []
@@ -145,7 +147,9 @@
                     "tags": []
                 }
             },
-            "meta": {},
+            "meta": {
+                "metabase.description": "Basic and derived order information from payments"
+            },
             "docs": {
                 "show": true
             },
diff --git a/tests/test_manifest.py b/tests/test_manifest.py
index 816272a9..e8755799 100644
--- a/tests/test_manifest.py
+++ b/tests/test_manifest.py
@@ -39,7 +39,7 @@ def test_v12():
                     ),
                     Column(
                         name="payment_method",
-                        description="The method used to complete a payment.",
+                        description="",
                     ),
                     Column(
                         name="order_id",
@@ -60,7 +60,7 @@ def test_v12():
                 group=Group.nodes,
                 name="customers",
                 alias="customers",
-                description="Contains customer details and derived order facts",
+                description="This table has basic information about a customer, as well as some derived facts based on a customer's orders",
                 display_name="clients",
                 unique_id="model.sandbox.customers",
                 columns=[
@@ -258,7 +258,7 @@ def test_v2():
                 group=Group.nodes,
                 name="orders",
                 alias="orders",
-                description="This table has basic information about orders, as well as some derived facts based on payments",
+                description="Basic and derived order information from payments",
                 unique_id="model.jaffle_shop.orders",
                 columns=[
                     Column(
@@ -278,7 +278,7 @@ def test_v2():
                     ),
                     Column(
                         name="status",
-                        description="Orders can be one of the following statuses:\n\n| status         | description                                                                                                            |\n|----------------|------------------------------------------------------------------------------------------------------------------------|\n| placed         | The order has been placed but has not yet left the warehouse                                                           |\n| shipped        | The order has ben shipped to the customer and is currently in transit                                                  |\n| completed      | The order has been received by the customer                                                                            |\n| return_pending | The customer has indicated that they would like to return the order, but it has not yet been received at the warehouse |\n| returned       | The order has been returned by the customer and received at the warehouse                                              |",
+                        description="Order status: placed, shipped, completed, return_pending, or returned.",
                     ),
                     Column(
                         name="amount",