From 7851de0bb8c6e813a06f80b9ae1150f67fa2c494 Mon Sep 17 00:00:00 2001 From: ValentinVignal Date: Tue, 22 Oct 2024 14:44:41 +0800 Subject: [PATCH] refactor: Add const constructor to visitors --- docs/customization.md | 2 +- packages/ferry/lib/src/add_typename_typed_link.dart | 2 +- packages/ferry_generator/lib/src/utils/add_introspection.dart | 2 ++ packages/normalize/lib/src/denormalize_fragment.dart | 2 +- packages/normalize/lib/src/denormalize_operation.dart | 2 +- packages/normalize/lib/src/normalize_fragment.dart | 2 +- packages/normalize/lib/src/normalize_operation.dart | 2 +- packages/normalize/lib/src/utils/add_typename_visitor.dart | 2 ++ packages/normalize/lib/src/utils/validate_structure.dart | 2 +- packages/normalize/lib/src/utils/well_known_directives.dart | 4 +++- 10 files changed, 14 insertions(+), 8 deletions(-) diff --git a/docs/customization.md b/docs/customization.md index f14b602b..dcf72884 100644 --- a/docs/customization.md +++ b/docs/customization.md @@ -69,7 +69,7 @@ class AddTypenameTypedLink extends TypedLink { ..operation = Operation( document: transform( request.operation.document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ), operationName: request.operation.operationName, ), diff --git a/packages/ferry/lib/src/add_typename_typed_link.dart b/packages/ferry/lib/src/add_typename_typed_link.dart index 73da21cd..5ec21ba6 100644 --- a/packages/ferry/lib/src/add_typename_typed_link.dart +++ b/packages/ferry/lib/src/add_typename_typed_link.dart @@ -22,7 +22,7 @@ class AddTypenameTypedLink extends TypedLink { (op) => Operation( document: transform( op.document, - [ + const [ AddTypenameVisitor(), ], ), diff --git a/packages/ferry_generator/lib/src/utils/add_introspection.dart b/packages/ferry_generator/lib/src/utils/add_introspection.dart index 7f9eb73c..0aacb4e3 100644 --- a/packages/ferry_generator/lib/src/utils/add_introspection.dart +++ b/packages/ferry_generator/lib/src/utils/add_introspection.dart @@ -14,6 +14,8 @@ const typenameField = FieldDefinitionNode( ); class AddTypenameField extends TransformingVisitor { + const AddTypenameField(); + @override ObjectTypeDefinitionNode visitObjectTypeDefinitionNode( ObjectTypeDefinitionNode node, diff --git a/packages/normalize/lib/src/denormalize_fragment.dart b/packages/normalize/lib/src/denormalize_fragment.dart index f5030478..c5c61da9 100644 --- a/packages/normalize/lib/src/denormalize_fragment.dart +++ b/packages/normalize/lib/src/denormalize_fragment.dart @@ -40,7 +40,7 @@ Map? denormalizeFragment({ if (addTypename) { document = transform( document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ); } final fragmentMap = getFragmentMap(document); diff --git a/packages/normalize/lib/src/denormalize_operation.dart b/packages/normalize/lib/src/denormalize_operation.dart index 3c840716..782ca355 100644 --- a/packages/normalize/lib/src/denormalize_operation.dart +++ b/packages/normalize/lib/src/denormalize_operation.dart @@ -35,7 +35,7 @@ Map? denormalizeOperation({ if (addTypename) { document = transform( document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ); } diff --git a/packages/normalize/lib/src/normalize_fragment.dart b/packages/normalize/lib/src/normalize_fragment.dart index 667842d7..b3876843 100644 --- a/packages/normalize/lib/src/normalize_fragment.dart +++ b/packages/normalize/lib/src/normalize_fragment.dart @@ -44,7 +44,7 @@ void normalizeFragment({ // Always add typenames to ensure data is stored with typename document = transform( document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ); final fragmentMap = getFragmentMap(document); diff --git a/packages/normalize/lib/src/normalize_operation.dart b/packages/normalize/lib/src/normalize_operation.dart index 04caa2a1..78517750 100644 --- a/packages/normalize/lib/src/normalize_operation.dart +++ b/packages/normalize/lib/src/normalize_operation.dart @@ -40,7 +40,7 @@ void normalizeOperation({ if (addTypename) { document = transform( document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ); } diff --git a/packages/normalize/lib/src/utils/add_typename_visitor.dart b/packages/normalize/lib/src/utils/add_typename_visitor.dart index 87ca3369..598d30ae 100644 --- a/packages/normalize/lib/src/utils/add_typename_visitor.dart +++ b/packages/normalize/lib/src/utils/add_typename_visitor.dart @@ -1,6 +1,8 @@ import 'package:gql/ast.dart'; class AddTypenameVisitor extends TransformingVisitor { + const AddTypenameVisitor(); + @override FieldNode visitFieldNode(FieldNode node) { if (node.selectionSet == null) { diff --git a/packages/normalize/lib/src/utils/validate_structure.dart b/packages/normalize/lib/src/utils/validate_structure.dart index 307abbad..b0342807 100644 --- a/packages/normalize/lib/src/utils/validate_structure.dart +++ b/packages/normalize/lib/src/utils/validate_structure.dart @@ -97,7 +97,7 @@ bool _validateSelectionSet({ if (addTypename) { document = transform( document, - [AddTypenameVisitor()], + const [AddTypenameVisitor()], ); } final fragmentMap = getFragmentMap(document); diff --git a/packages/normalize/lib/src/utils/well_known_directives.dart b/packages/normalize/lib/src/utils/well_known_directives.dart index 40d4b71f..addf8872 100644 --- a/packages/normalize/lib/src/utils/well_known_directives.dart +++ b/packages/normalize/lib/src/utils/well_known_directives.dart @@ -41,7 +41,9 @@ bool isSkipped(SelectionNode node, Map variables) { class _SelectionNodeDirectiveVisitor extends SimpleVisitor?> { - static final instance = _SelectionNodeDirectiveVisitor(); + const _SelectionNodeDirectiveVisitor(); + + static const instance = _SelectionNodeDirectiveVisitor(); @override List visitFieldNode(FieldNode node) {