diff --git a/codegen/gql_tristate_value/lib/src/value.dart b/codegen/gql_tristate_value/lib/src/value.dart index 0afb02aa..1a4233f5 100644 --- a/codegen/gql_tristate_value/lib/src/value.dart +++ b/codegen/gql_tristate_value/lib/src/value.dart @@ -16,9 +16,9 @@ sealed class Value { /// If the value is non-null, it will be serialized as the value. /// If the value is null. It will not be serialized. - factory Value.ofNullable(T? value) { + factory Value.absentWhenNull(T? value) { if (value == null) { - return AbsentValue(); + return const AbsentValue(); } return Value.present(value); } diff --git a/codegen/gql_tristate_value/test/value_test.dart b/codegen/gql_tristate_value/test/value_test.dart index 5a12777f..ae96e5a2 100644 --- a/codegen/gql_tristate_value/test/value_test.dart +++ b/codegen/gql_tristate_value/test/value_test.dart @@ -5,32 +5,32 @@ void main() { group( 'requireValue', () { - test('on $AbsentValue throws', () { + test('on AbsentValue throws', () { final absent = const AbsentValue(); expect(() => absent.requireValue, throwsA(isA())); }); - test('on $PresentValue with valuereturns value', () { + test('on PresentValue with valuereturns value', () { final present = Value.present(42); expect(present.requireValue, equals(42)); }); - test('on $PresentValue with null returns null', () { + test('on PresentValue with null returns null', () { final nullValue = Value.present(null); expect(nullValue.requireValue, isNull); }); - test('on ${Value.ofNullable} with value returns value', () { - final present = Value.ofNullable(42); + test('on Value.ofNullable with value returns value', () { + final present = Value.absentWhenNull(42); expect(present.requireValue, equals(42)); }); - test('on ${Value.ofNullable} with null throws', () { - final nullValue = Value.ofNullable(null); + test('on Value.ofNullable with null throws', () { + final nullValue = Value.absentWhenNull(null); expect(() => nullValue.requireValue, throwsA(isA())); }); @@ -38,28 +38,28 @@ void main() { ); group( - 'valueOrNull ', + 'valueOrNull', () { - test('on $AbsentValue returns null', () { + test('on AbsentValue returns null', () { final absent = const AbsentValue(); expect(absent.valueOrNull, isNull); }); - test('on $PresentValue with value returns value', () { + test('on PresentValue with value returns value', () { final present = Value.present(42); expect(present.valueOrNull, equals(42)); }); - test('on ${Value.ofNullable} with value returns value', () { - final present = Value.ofNullable(42); + test('on Value.ofNullable with value returns value', () { + final present = Value.absentWhenNull(42); expect(present.valueOrNull, equals(42)); }); - test('on ${Value.ofNullable} with null returns null', () { - final present = Value.ofNullable(null); + test('on Value.ofNullable with null returns null', () { + final present = Value.absentWhenNull(null); expect(present.valueOrNull, isNull); }); @@ -67,28 +67,28 @@ void main() { ); group( - 'isPresent ', + 'isPresent', () { - test('on $AbsentValue returns false', () { + test('on AbsentValue returns false', () { final absent = const AbsentValue(); expect(absent.isPresent, false); }); - test('on $PresentValue with value returns true', () { + test('on PresentValue with value returns true', () { final present = Value.present(42); expect(present.isPresent, true); }); - test('on ${Value.ofNullable} with value returns true', () { - final present = Value.ofNullable(42); + test('on Value.ofNullable with value returns true', () { + final present = Value.absentWhenNull(42); expect(present.isPresent, true); }); - test('on ${Value.ofNullable} with null returns false', () { - final present = Value.ofNullable(null); + test('on Value.ofNullable with null returns false', () { + final present = Value.absentWhenNull(null); expect(present.isPresent, false); }); @@ -96,9 +96,9 @@ void main() { ); group( - 'toString ', + 'toString', () { - test('on $PresentValue', () { + test('on PresentValue', () { final present = Value.present(42); expect(present.toString(), 'PresentValue(value: 42)');