Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event handling broken since Grafana 8 introduced React #17

Closed
amotl opened this issue Sep 20, 2022 · 3 comments
Closed

Event handling broken since Grafana 8 introduced React #17

amotl opened this issue Sep 20, 2022 · 3 comments

Comments

@amotl
Copy link
Contributor

amotl commented Sep 20, 2022

Hi there,

since Grafana 8 introduced React, grafanimate is having a hard time to properly synchronize with the frontend in order to capture frames efficiently. More information can be found at 1.

With kind regards,
Andreas.

Footnotes

  1. https://community.grafana.com/t/how-to-add-event-handler-in-grafana-8-react-panel-plugins/58668/4.

@amotl amotl changed the title Event handling broken since Grafana 8 Event handling broken since Grafana 8 introduced React Sep 20, 2022
@amotl
Copy link
Contributor Author

amotl commented Oct 15, 2023

@intermittentnrg apparently found a solution for newer versions of Grafana, and submitted GH-19, reflecting that. Thanks a stack!

The code just invokes grafanaRuntime.getPanelData() and checks the result items for state=='Done', without further ado. It could have been so easy! ;]

It is still a synthesized event handling, but much better than waiting for unknown amounts of time through the currently implemented exposure-time option.

@maurerle
Copy link
Collaborator

maurerle commented Dec 2, 2024

this was fixed in #32

@maurerle maurerle closed this as completed Dec 2, 2024
@amotl
Copy link
Contributor Author

amotl commented Dec 3, 2024

Thanks for your excellent contributions, @maurerle.

/cc @wetterfrosch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants