Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.address or peer.addres may refer to service by the same across namespaces #1246

Open
esara opened this issue Oct 11, 2024 · 2 comments

Comments

@esara
Copy link
Contributor

esara commented Oct 11, 2024

In the current implementation, the server address or the client address - when resolved from k8s - is only the short name (not fully qualified)

If the client and/or the server are in different namespaces - while the resource attributes spells out the namespace, it is not obvious if the span.client or span.server refers to a client/server in the same namespace or another namespace

@grcevski
Copy link
Contributor

Thanks for reporting this Endre, I am curious if this is desired for traces and metrics or just traces?

@esara
Copy link
Contributor Author

esara commented Oct 17, 2024

I am primarily looking at traces with beyla. In this case specifically, the nature of a span to show the resource and span attributes, often referring to the client as the resource and the server as the server address in the span attributes.

And while making assumption that communication is often within a namespace is bad, if the span is created in a crossnamespace span, it is not clear what server the server address is referring to.

For metrics, if it is just server metrics metrics, there would be no confusion, because it is only one side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants