Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart for CRDs #505

Open
DanielCastronovo opened this issue Dec 11, 2024 · 3 comments · May be fixed by #507
Open

Helm chart for CRDs #505

DanielCastronovo opened this issue Dec 11, 2024 · 3 comments · May be fixed by #507
Labels
enhancement New feature or request helm

Comments

@DanielCastronovo
Copy link

Feature Description

Helm chart for CRDs instead on the K6 helm chart

Suggested Solution (optional)

Helm chart for CRDs instead on the K6 helm chart

Already existing or connected issues / PRs (optional)

No response

@yorugac
Copy link
Collaborator

yorugac commented Jan 2, 2025

Hi @DanielCastronovo, sorry for the delay; it's been a holiday season. Hope you had a nice Christmas and New Year!

Could you please provide additional points as to why you wish for additional Helm chart? I've been grokking this slightly on my days off and I have some reservations about such a change. So additional clarification on the use cases, pros and cons from your perspective would be helpful.

@DanielCastronovo
Copy link
Author

Hi, sure Helm doesn't support CRDs upgrade, so major helm chart with CRD have 2 helm distinct helm chart :

  • for the app
  • for CRDs

It's enable to programmatically and not by manual steps to bump a new CRDs.

Pros :

  • IAC support
  • Gitops
  • No more manuels steps
  • Reduce the maintenance process
  • Specific changelog and release note (give much visibility on BR)

Cons :

  • Need 2 charts

@yorugac
Copy link
Collaborator

yorugac commented Jan 22, 2025

Hi @DanielCastronovo, thanks for the write up!

I've been looking around for an alternative solution and it appears that there are hooks that could be utilized to help with upgrades as well. That is, chart hooks pre-upgrade. I didn't try it myself, but it sounds like there can be a Job executed one each upgrade that could update the CRDs. I.e. it should cover most of the points you raised. (except the changelog thing but we also track this in #344) WDYT?

Just to be clear, I'm definitely all for improving the experience with Helm chart; it's just adding a new chart to maintain would take additional time that I need to plan for. And if it's possible to have an alternative solution that won't complicate maintenance of k6-operator too much, that'd be great.

cc @mariuskimmina since you worked on a related PR 🙂

@yorugac yorugac added the helm label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants