Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Extend the playwright config file #1366

Open
2 of 7 tasks
jackw opened this issue Nov 29, 2024 · 0 comments · May be fixed by #1495
Open
2 of 7 tasks

Feat: Extend the playwright config file #1366

jackw opened this issue Nov 29, 2024 · 0 comments · May be fixed by #1495
Assignees
@oshirohugo
Labels
create-plugin related to the create-plugin tool enhancement New feature or request good first issue Good for newcomers

Comments

@jackw
Copy link
Collaborator

jackw commented Nov 29, 2024 •
edited
Loading

Which areas does this feature request relate to

  • Create Plugin
  • Sign Plugin
  • Plugin E2E
  • Plugin Meta Extractor
  • Documentation

Problem

New plugin scaffolds create a playwright.config.ts in the root of the project with configuration that we might want to change at a later date. Because it lives in the root developers are free to edit it as they wish which could make it complicated to update in the future.

Solution

Move the base playwright config settings into a ./.config/playwright.config.ts and then extend the root file in the same way we do for other config files.

Alternatives

No response

Additional context

No response

Are you interested in contributing the solution?

  • Yes
  • No
@jackw jackw added create-plugin related to the create-plugin tool enhancement New feature or request good first issue Good for newcomers labels Nov 29, 2024
@mckn mckn moved this from 📬 Triage to 📅 Planned in Plugins Platform / Grafana Community Dec 2, 2024
@oshirohugo oshirohugo self-assigned this Jan 27, 2025
@oshirohugo oshirohugo moved this from 📅 Planned to 🧑‍💻 In development in Plugins Platform / Grafana Community Jan 27, 2025
@oshirohugo oshirohugo linked a pull request Jan 28, 2025 that will close this issue
Open
@oshirohugo oshirohugo moved this from 🧑‍💻 In development to 🔬 In review in Plugins Platform / Grafana Community Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oshirohugo oshirohugo

Labels
create-plugin related to the create-plugin tool enhancement New feature or request good first issue Good for newcomers
Projects
Plugins Platform / Grafana Community
Status: 🔬 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Plugin: Extend the playwright config file grafana/plugin-tools
2 participants
@jackw @oshirohugo