Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: base branch of this set to #3946. do not merge
Tenant settings ruler is a thread-safe ruler that obtains rules from tenant-settings service and caches the result for later calls.
It holds a cache for each tenant, that expires after the default time (60s).
Every first call to a tenant for
RecordingRules(tenant string)
will initialize the per-tenant cache. When calling again the method, the cached rules will be served unless they expired. In that case, cache will be refreshed.I discarded doing generics here becase (1) I would like to validate the idea first and (2) there's no need to generalize the cache.
Ruler needs a tenant settings client in place, I will create dependencies after @bryanhuhta.
Some detected todos: