feat(v2): hedged object uploads #3952
Open
+509
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
changed the title
korniltsev
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the segment-writer and compaction-worker services do not retry block uploads.
This is acceptable in most cases, as cloud providers typically ensure high availability. However, issues like tail request latencies, transient errors, network blips, and others could be mitigated with a retry policy.
The PR introduces retries and hedging for segment uploads. I'll add upload retries for compaction workers in a separate PR.
The screenshot below shows how a successful hedged upload (triggered after 500ms) prevented a tail latency spike – a slower request that could have lasted seconds (p100)