Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grails-quartz for Grails 7 #131

Closed
jamesfredley opened this issue Oct 21, 2024 · 4 comments
Closed

Update grails-quartz for Grails 7 #131

jamesfredley opened this issue Oct 21, 2024 · 4 comments
Assignees

Comments

@jamesfredley
Copy link
Contributor

jamesfredley commented Oct 21, 2024

4.0.x branch has been created for Grails 7: https://github.com/grails/grails-quartz

@jamesfredley jamesfredley converted this from a draft issue Oct 21, 2024
@jdaugherty
Copy link
Contributor

Internally, we use the quartz spring starter and it works perfectly as-is. What are people's thoughts about publishing a guide for this way instead?

@jdaugherty
Copy link
Contributor

FYI: quartz-scheduler/quartz#1134 - quartz was released so it should work with the jakarta packages now

@amondel2 amondel2 moved this from Todo to In Progress in Grails 7 Dec 13, 2024
@amondel2 amondel2 self-assigned this Dec 13, 2024
@amondel2
Copy link
Contributor

@jamesfredley I made some updates for this plugin for Java 17 (this was mostly done already), Spring 6.2.0, and Grails 7.0.0-snapshot in my branch. Before I do the MR where do we stand on the following.

  1. Keep or remove buildSrc dir?
  2. Cleaning up the .toml and .gradle files in https://github.com/grails/grails-quartz/tree/4.0.x/gradle and moving the versions to gradle.properties?

@jamesfredley
Copy link
Contributor Author

@amondel2

Grails projects are currently split with and without buildSrc. I personally like without because it is simpler and version management is not independent, but it is up to you. For start.grails.org generated projects on 6.2.2 and 7.0.0 default to without buildSrc.

Most Grails projects do not use .toml. For the ones that do, it is possible to use versions from grails-bom and remove most of the versions from .toml files. It would also be OK to convert away from .toml, if you want to go this direction. Toml is cool, but it takes more time to see what it is doing, IMO.

A good example of removing most versions from .toml: https://github.com/grails/grails-spring-security-core/pull/1034/files
Anything with a version in https://repo.grails.org/ui/repos/tree/PomView/libs-snapshots-local/org/grails/grails-bom/7.0.0-SNAPSHOT/grails-bom-7.0.0-20241213.003552-182.pom can have the version removed.

@amondel2 amondel2 moved this from In Progress to Done in Grails 7 Dec 20, 2024
@amondel2 amondel2 closed this as completed by moving to Done in Grails 7 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants