Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emscripten and FS manual declaration #12

Open
dfober opened this issue Jun 25, 2020 · 5 comments
Open

emscripten and FS manual declaration #12

dfober opened this issue Jun 25, 2020 · 5 comments

Comments

@dfober
Copy link
Member

dfober commented Jun 25, 2020

I note that emscripten functions and FS are manually declared in libFaustLoader.d.ts
You could probably save time and maintenance effort by using the existing types declarations available from npm

@Fr0stbyteR
Copy link

The Emscripten d.ts was not complete while I developed the project. I'm not sure if it works better now...

@dfober
Copy link
Member Author

dfober commented Jun 25, 2020

I see, @types/emscripten is already part of the package. The version has evolved (1.39.4), maybe it's worth a try.
It seems to work with FS but I don't know how to do with the LibFaust (extends EmscriptenModule).
Actually, it seems that you only declared FS, right?

@Fr0stbyteR
Copy link

Fr0stbyteR commented Jun 25, 2020

Yes indeed, LibFaust is extended from EmscriptenModule from @types/emscripten with some additional methods and FS.

@dfober
Copy link
Member Author

dfober commented Jun 25, 2020

seems like it's not necessary any more.
I'll do some tests and I'll keep you informed.

@dfober
Copy link
Member Author

dfober commented Jun 25, 2020

Seems to work as expected. I've pushed the change on a new branch named 'dom'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants