Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make bot.catch work on webhooks #702

Closed
Tracked by #675
KnorpelSenf opened this issue Dec 15, 2024 · 2 comments
Closed
Tracked by #675

feat: make bot.catch work on webhooks #702

KnorpelSenf opened this issue Dec 15, 2024 · 2 comments

Comments

@KnorpelSenf
Copy link
Member

Many developers are confused by this so we should just respect any error handlers if they are set. If no error handlers are set via bot.catch, errors will still be passed to the surrounding HTTP server lib.
@KnorpelSenf KnorpelSenf mentioned this issue Dec 15, 2024
Open
51 tasks
@shevernitskiy shevernitskiy mentioned this issue Jan 16, 2025
Merged
@KnorpelSenf
Copy link
Member Author

Fixed by #741

@KnorpelSenf
Copy link
Member Author

@shevernitskiy we might want to do #697 (comment) now that this is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnorpelSenf